Closed
Bug 1425550
Opened 6 years ago
Closed 6 years ago
Output frame tree when retained display list checker finds an issue
Categories
(Core :: Web Painting, enhancement)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(1 file)
Seeing the frame tree could help find causes of RDL issues.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8937144 [details] Bug 1425550 - Output frame tree when RDL checker finds issues - https://reviewboard.mozilla.org/r/207858/#review213734 How frequent are failures now (with the subdoc patch). Can we add an NS_ASSERTION as well so that the failures create an orange?
Attachment #8937144 -
Flags: review?(matt.woodrow) → review+
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to Matt Woodrow (:mattwoodrow) from comment #2) > Comment on attachment 8937144 [details] > Bug 1425550 - Output frame tree when RDL checker finds issues - > > https://reviewboard.mozilla.org/r/207858/#review213734 Thank you Matt for the review. > How frequent are failures now (with the subdoc patch). Can we add an > NS_ASSERTION as well so that the failures create an orange? There are way fewer failures now, but last I looked there are still a few failures scattered around most test groups, such that it would probably make most tries look very orange! I will open a separate bug for that, and launch an experiment (after bug 1418840 lands) to gather some up-to-date data...
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3eab9fd44dda Output frame tree when RDL checker finds issues - r=mattwoodrow
| Comment hidden (mozreview-request) |
|
||
Comment 6•6 years ago
|
||
Backed out for build bustages on build/src/layout/base/nsLayoutUtils.cpp:3888:21 https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3eab9fd44dda8e939027988572ef76270da35cce&filter-resultStatus=busted https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3eab9fd44dda8e939027988572ef76270da35cce&filter-resultStatus=busted https://hg.mozilla.org/integration/autoland/rev/3b74c325e10f3ce6a6989ad1c0f9146133e29c50
Flags: needinfo?(gsquelart)
|
|
Assignee | |
Comment 7•6 years ago
|
||
On it. Thank you Cosmin, and sorry for the trouble.
Flags: needinfo?(gsquelart)
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dccea4ad69cb Output frame tree when RDL checker finds issues - r=mattwoodrow
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dccea4ad69cb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•