Closed Bug 1425876 Opened 6 years ago Closed 6 years ago

Update Debugger Frontend (12-18)

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Version:
57 Branch
Type:
defect

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

patch-12-18-6.patch
113.39 KB, patch
jdescottes
: review+
Details | Diff | Splinter Review 
      No description provided.

        Attachment #8937695 -
        Flags: review?(jdescottes)
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3

    
    

    
  
ignore the latest try runs :)

    
    

    
  
Comment on attachment 8937695 [details] [diff] [review]
patch-12-18-6.patch

Review of attachment 8937695 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Spotted one issue, not a regression, according to :jlast already being fixed:

When paused, editor always keeps scrolling back to the paused line. STRs:
- add a breakpoint on a source file big enough to have scrollbar
- hit breakpoint
- scroll somewhere else, try to add a breakpoint
=> breakpoint is added but scrolls immediately to the paused line, very surprising for the user

        Attachment #8937695 -
        Flags: review?(jdescottes) → review+

    
    

    
  
Can we get a commit list and some GH links, same as what you originally provided on Bug 1425912.

Thanks
Flags: needinfo?(jlaster)

    
    

    
  
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbd296b011c1
Update Debugger frontend (12-18). r=jdescottes

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/fbd296b011c1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox59:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59

    
    

    
  
I believe this is it.

https://github.com/devtools-html/debugger.html/compare/2d50f0e...2d9347c
Flags: needinfo?(jlaster)

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: