1426016 - [meta] Convert add-ons manager to fluent

Status: NEW

(Toolkit :: Add-ons Manager, task, P5)

Description

[Carlos [nohamelin]]

Attachment: mixed-languages-in-AM.png

Nightly 59.0a1 20171218220523, but it surely happens with release too.

Steps
-----

* Ensure that the UI language application is correctly set to English.
* Open the Add-ons Manager: the UI is in English, and, if the add-on supports it, all its metadata is displayed in English too.
* Install an language pack, let's say Spanish es-ES.
* Change the UI language to es-ES (intl.locale.requested preference in Nightly, general.useragent.locale otherwise).
* Close the Add-ons Manager and open it again.


Expected results
----------------
All Add-ons Manager in Spanish, excepting metadata of add-ons not supporting this language.


Results
-------
See attachment; two problems:
* Names of panels are still displayed in English.
* Metadata of ublock origin is still displayed in English, even when this add-on actually has a Spanish localization.

After restarting the application, these two texts are displayed in Spanish, as expected. A restart shouldn't be neccesary.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

This will be fixed only once Fluent replaces the current l10n API in Addons Manager. We don't have a bug for that switch yet, so I'll set it as a dependency for the general tracking bug for Fluent.

Comment 2

[Andrew Swan [:aswan]]

Clarifying the title.  Priority is kind of meaningless at this point since Fluent needs some time to stabilize first and we need to nail down our long term plans re about:addons.  So P5 for now so this is considered triaged, to be revisited when those things get addressed.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Some students that Gijs, jaws and I are mentoring are likely to take this on.

Marking meta since this will likely be divided up between students across different parts of about:addons.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

These are the strings in extensions.dtd that are also used in XBL bindings, meaning that (as far as I understand), they can't be ported to Fluent just yet (until the bindings go away):

cmd.enableAddon.label
cmd.disableAddon.label
cmd.askToActivate.label
cmd.askToActivate.tooltip
cmd.alwaysActivate.label
cmd.alwaysActivate.tooltip
cmd.neverActivate.label
cmd.neverActivate.tooltip
cmd.stateMenu.tooltip
cmd.uninstallAddon.label
cmd.showPreferencesWin.label
cmd.showPreferencesWin.tooltip
cmd.showPreferencesUnix.label
cmd.showPreferencesUnix.tooltip
cmd.showReleaseNotes.label
cmd.showReleaseNotes.tooltip
cmd.hideReleaseNotes.label
cmd.hideReleaseNotes.tooltip
cmd.findReplacement.label
progress.cancel.tooltip
addon.details.label
addon.details.tooltip
addon.unknownDate
addon.legacy.label
addon.disabled.postfix
addon.update.postfix
addon.undoAction.label
addon.undoAction.tooltip
addon.undoRemove.label
addon.undoRemove.tooltip
addon.install.label
addon.install.tooltip
addon.updateNow.label
addon.updateNow.tooltip
addon.includeUpdate.label
addon.updateAvailable.label
addon.checkingForUpdates.label
addon.releaseNotes.label
addon.loadingReleaseNotes.label
addon.errorLoadingReleaseNotes.label
addon.createdBy.label

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Is it now fixed?

Comment 6

[Mark Striemer [:mstriemer]]

This is not yet fixed. There are still two main tasks to achieve mostly fluent: the heading in HTML (underway) and the sidebar in HTML. Once those are done about:addons will be close but we have reused some old strings to avoid re-translation late in a cycle, so those will need to be migrated. I'll file blockers on this bug for those.