1426122 - Extension stuck in "Checking for updates..." mode

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[marius.santa]

Attachment: stuck checking.gif

[Affected versions]:
Firefox 59.0a1 (20171217220404)

[Affected platforms]:
Windows 10 64-bit
MacOS Sierra 10.13


[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install a previous version of any extension.
3.Go to "about:addons".
4.Click on the "More" button for the installed extension.
5.Set "Automatic Updates" to "Off".
6.Click on the "Extensions" tab and perform a "Check for Updates" operation from "Tools for all add-ons".
7.Right click on the extension and select "Find Updates".

[Expected Results]:
The updates are displayed.

[Actual Results]:
The "Checking for Updates..." message is stuck. The user has to refresh the page in order to be able to use any of the options available for the selected addon.


[Additional notes]:
Gif of issue attached.

Comment 1

[Andrew Swan [:aswan]]

It looks like the issue here is that in the sequence of events described here, we get an "onUpdateAvailable" callback (as opposed to an onNewInstall callback if we skip step 6).  And the addon-generic XBL binding doesn't handle that event.  Fixing this is just a matter of adding that method, all I think it needs to do is call `this._showStatus("update-available");`

Dropping the priority since this requires such a specific sequence of events to trigger, and since this is code we'd like to get rid of anyway...

Comment 2

[yadavallisasank]

Hey,

I would like work on the issue as I am learning to work on open source projects. Is it possible if you can assign this to me and I would love to contribute? Thanks a lot

Comment 3

[Andrew Swan [:aswan]]

Sure, thanks for your interest!  I've assigned the bug to you.

If you haven't already done it, building Firefox locally is the first step.  There's an overview here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
But for this bug you should be able to use artifact builds as well, see the docs here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds

The code in question is in the file toolkit/mozapps/extensions/content/extensions.xml.  I'm not sure how much background you need to get started, please feel free to add comments here with any questions you have, and set the needinfo flag (by clicking the checkbox next to "Need more information from" and entering my name in the text box at the bottom of the page)

Comment 4

[Caitlin Neiman [:caitmuenster]]

Hey yadavallisasank! Just wanted to check in and see how it's going with this bug.

Comment 5

[Caitlin Neiman [:caitmuenster]]

Hi yadavallisasank, since we haven't heard from you in awhile we are going to unassign you from this bug. If you have a little bit more time in the future, please come back and submit a patch!

Comment 6

[Mihir Karbelkar(:fauxwizard_)]

Hi can I work on this bug since nobody is assigned to it. Also which part of Firefox is the bug related to? Thanks.

Comment 7

[Mihir Karbelkar(:fauxwizard_)]

Also can I take 2-3 days as I am out of town?

Comment 8

[Mihir Karbelkar(:fauxwizard_)]

Is the bug still open?

Comment 9

[Mihir Karbelkar(:fauxwizard_)]

I can not reproduce it on firefox.

Comment 10

[Sijmen Schoon]

I just reproduced this on Firefox 64.0.2 on Windows 10 (1803), so the bug is still there.

Comment 11

[Martin Koroknay]

Hi, I'd be more than happy to take this one on as my first contribution to open source. Could it be assigned to me please? Thanks!

Comment 12

[Caitlin Neiman [:caitmuenster]]

Hey Martin, welcome! If you haven't done so already, you might want to read our onboarding documentation before getting started: https://wiki.mozilla.org/WebExtensions/Contribution_Onramp

If you need any help, please needinfo :aswan, the bug's mentor.

Happy bug fixing!

Comment 13

[Martin Koroknay]

Attachment: Bug 1426122 fix patch

Comment 14

[Martin Koroknay]

(In reply to Caitlin Neiman [:caitmuenster] from comment #12)

Thanks Caitlin. I have attached my patch now, which I have tested and should fix the bug.

Comment 15

[Martin Koroknay]

Attachment: Bug 1426122 - Fix extensions getting stuck in "Checking for updates" mode. r=aswan

Fix extensions getting stuck in "Checking for updates" mode

Comment 16

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/integration/autoland/rev/42eab2ed3806

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/42eab2ed3806

Comment 18

[Caitlin Neiman [:caitmuenster]]

Thanks so much, Martin! Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition

Would you be interested in creating an account on mozillians.org? I'd be happy to vouch for you!