Closed Bug 1426868 Opened 6 years ago Closed 6 years ago

Crash in mozilla::a11y::NotificationController::WillRefresh

Categories

(Core :: Disability Access APIs, defect)

59 Branch
Unspecified
Windows 10
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- verified

People

(Reporter: calixte, Assigned: samuel.thibault)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression, Whiteboard: [clouseau])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-17a3c98c-594f-4333-88fe-a4a1e0171222.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::a11y::NotificationController::WillRefresh accessible/base/NotificationController.cpp:645
1 xul.dll nsRefreshDriver::Tick layout/base/nsRefreshDriver.cpp:1862
2 xul.dll nsRefreshDriver::DoTick layout/base/nsRefreshDriver.cpp:1484
3 xul.dll nsRefreshDriver::DoRefresh layout/base/nsRefreshDriver.cpp:2316
4 xul.dll nsRefreshDriver::FinishedWaitingForTransaction layout/base/nsRefreshDriver.cpp:2154
5 xul.dll nsRefreshDriver::NotifyTransactionCompleted layout/base/nsRefreshDriver.cpp:2221
6 xul.dll mozilla::layers::ClientLayerManager::DidComposite gfx/layers/client/ClientLayerManager.cpp:520
7 xul.dll mozilla::dom::TabChild::DidComposite dom/ipc/TabChild.cpp:3230
8 xul.dll mozilla::layers::CompositorBridgeChild::RecvDidComposite gfx/layers/ipc/CompositorBridgeChild.cpp:547
9 xul.dll mozilla::layers::PCompositorBridgeChild::OnMessageReceived ipc/ipdl/PCompositorBridgeChild.cpp:1441

=============================================================

There are 14 crashes in nightly 59 with buildid 20171222100407. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1425932.

[1] https://hg.mozilla.org/mozilla-central/rev/09e57c36e8da
Flags: needinfo?(samuel.thibault)
Samuel, could it be that parent's WillRefresh kills the child document?
Attached patch fixSplinter Review
Oh, that can be, indeed, here is a fix.
Flags: needinfo?(samuel.thibault)
Attachment #8938755 - Flags: review?(surkov.alexander)
Attachment #8938755 - Flags: review?(surkov.alexander) → review+
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cdac2f62179
Check that child document still exists after parent processing r=surkov
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4cdac2f62179
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
No more crashes after the patch landed.
Assignee: nobody → samuel.thibault
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: