1427114 - text-align-match-parent-01.html not found by WPT infra

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Sam Sneddon [:gsnedders]]

Attachment: unclosed-el.diff

This is caused by an unclosed tag, meaning the <link rel="match"> doesn't actually get parsed. (Submitting this on Bugzilla because I spent about half an hour trying to get MozReview working and I couldn't…)

Comment 1

[Daniel Holbert [:dholbert]]

Thanks for the patch!  I'll rubberstamp it as r+, but technically this needs a commit message (to describe the change) and an author/"User" hg header before it can land.  Would you mind generating a patch that has those things and reposting?

(See instructions at https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F -- you can skip the "hg push review" part, since you noted MozReview was giving you trouble, and instead at that point just do "hg export tip > mypatch.patch", and if you've done things correctly, that should generate a patchfile that has your commit message and your name & email address in the first few lines.  Whereas the current attachment just has the diff with no other metadata.)

Comment 2

[Daniel Holbert [:dholbert]]

(In case it's not clear, compare the text of the current attachment to e.g. your older patch https://bug1231261.bmoattachments.org/attachment.cgi?id=8697402 which has proper headers)

If it takes more than a few minutes to get this working, I'm also happy to land it on your behalf and add some headers (using same authorship email address from that^^ older patch) -- just tag me for needinfo.

Comment 3

[Sam Sneddon [:gsnedders]]

Attachment: unclosed-el.diff

Comment 4

[Sam Sneddon [:gsnedders]]

Attachment: Bug 1427114 - Add missing ">" to unclosed meta element so WPT finds the test

Review commit: https://reviewboard.mozilla.org/r/210724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210724/

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8940479 [details]
Bug 1427114 - Add missing ">" to unclosed meta element so WPT finds the test

https://reviewboard.mozilla.org/r/210724/#review216450

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0127900b53d
Add missing ">" to unclosed meta element so WPT finds the test r=emilio

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d0127900b53d

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://github.com/w3c/web-platform-tests/pull/8942