Closed
Bug 1427821
Opened 6 years ago
Closed 6 years ago
Hooks don't save if they have invalid JSON
Categories
(Taskcluster :: UI, defect)
Taskcluster
UI
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin, Mentored)
Details
STR: * Edit a hook * Modify the body, leaving some invalid JSON * Click "save" Result: * looks like it saved the hook, but nothing changes Expected: * "save" button disabled, or at least an error message
Assignee | ||
Updated•6 years ago
|
Mentor: dustin
Assignee | ||
Comment 1•6 years ago
|
||
https://github.com/taskcluster/taskcluster-tools/pull/430
Comment 2•6 years ago
|
||
Commits pushed to master at https://github.com/taskcluster/taskcluster-tools https://github.com/taskcluster/taskcluster-tools/commit/835c6403c263c126ef90ab806d5385ea1071f942 Bug 1427821 - include triggerSchema in hook def after update This fixes a console error and failure to save. https://github.com/taskcluster/taskcluster-tools/commit/4cf185414734d65182c15add9d7301a67de370ea Bug 1427821 - only consider hook valid if JSON parses
Assignee | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: Tools → UI and Tools
You need to log in
before you can comment on or make changes to this bug.
Description
•