Closed
Bug 1427864
Opened 6 years ago
Closed 6 years ago
SM: Restore the dialogheader binding and its styling after the removal in bug 1419600
Categories
(SeaMonkey :: General, enhancement)
SeaMonkey
General
Tracking
(seamonkey2.56 fixed)
RESOLVED
FIXED
seamonkey2.56
| Tracking | Status | |
|---|---|---|
| seamonkey2.56 | --- | fixed |
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
Attachments
(5 files)
|
985 bytes,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
|
4.11 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
|
6.55 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
|
4.55 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
|
1.51 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
I have patches for this, just need to test a bit.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8941136 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Comment 3•6 years ago
|
||
header-large is only used in the profile selection dialog, so lets stop using that and move those rules to profile.css. Also, I think we should only have style rules in global.css for stuff that has toolkit bindings / style rules.
Attachment #8941140 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
Attachment #8941144 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8941143 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Comment 6•6 years ago
|
||
Attachment #8941145 -
Flags: review?(iann_bugzilla)
|
||
Updated•6 years ago
|
Blocks: 2.56BulkMalfunctions
Comment on attachment 8941136 [details] [diff] [review] Part 1: Use the c-c dialogheader binding r=me
Attachment #8941136 -
Flags: review?(iann_bugzilla) → review+
Comment on attachment 8941140 [details] [diff] [review] Part 2: Add missing style rules for Modern theme r=me
Attachment #8941140 -
Flags: review?(iann_bugzilla) → review+
Comment on attachment 8941143 [details] [diff] [review] Part 3: Copy windows profile.css to classic/mac/communicator/profile/ r=me
Attachment #8941143 -
Flags: review?(iann_bugzilla) → review+
|
||
Comment 10•6 years ago
|
||
Comment on attachment 8941144 [details] [diff] [review] Part 4: Add missing style rules for the Classic theme r=me
Attachment #8941144 -
Flags: review?(iann_bugzilla) → review+
Attachment #8941145 -
Flags: review?(iann_bugzilla) → review+
|
||
Comment 11•6 years ago
|
||
Pushed by stefanh@inbox.com: https://hg.mozilla.org/comm-central/rev/9964c99ea965 SM: Restore the dialogheader binding and its styling after the removal in bug 1419600, part 1: Use the c-c dialogheader binding. r=IanN. https://hg.mozilla.org/comm-central/rev/2a18c5427701 SM: Restore the dialogheader binding and its styling after the removal in bug 1419600, part 2: Add missing style rules for Modern theme. r=IanN. https://hg.mozilla.org/comm-central/rev/7eb3f6ef9e89 SM: Restore the dialogheader binding and its styling after the removal in bug 1419600, part 3: Copy windows profile.css to classic/mac/communicator/profile/. r=IanN. https://hg.mozilla.org/comm-central/rev/4a3f1b1488b6 SM: Restore the dialogheader binding and its styling after the removal in bug 1419600, part 4: Add missing style rules for the Classic theme. r=IanN. https://hg.mozilla.org/comm-central/rev/3b24922dc193 SM: Restore the dialogheader binding and its styling after the removal in bug 1419600, part 5: Remove the now obsolete 'header-large' class from profileSelection.xul. r=IanN.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
status-seamonkey2.56:
--- → fixed
Target Milestone: --- → Seamonkey2.56
You need to log in
before you can comment on or make changes to this bug.
Description
•