1428110 - Build fails with SDK Tools 25.2.5

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Matías Zúñiga]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171130114045

Steps to reproduce:

Start a new build of firefox for android from the latest mozilla-beta branch with Android SDK Tools 25.2.5


Actual results:

Fails at configure stage with:
checking for Android tools... /opt/AndroidSDK/tools
checking for emulator... :
checking for emulator... (cached) :
configure: error: The program emulator was not found.


Expected results:

Build should work as with the 57-branch.
Emulator is present at tools/emulator

Comment 1

[Nick Alexander :nalexander [he/him]]

Matias: thanks for the report!  I think that we don't support 25.2.5; we require 25.0.3 for beta, I believe.  You can check by looking for the versions in https://searchfox.org/mozilla-central/source/old-configure.in#2147.

gbrown: is this related to https://bugzilla.mozilla.org/show_bug.cgi?id=1390606?

Comment 2

[Matías Zúñiga]

(In reply to Nick Alexander :nalexander (less responsive until Jan 3, 2018) from comment #1)
> Matias: thanks for the report!  I think that we don't support 25.2.5; we
> require 25.0.3 for beta, I believe.  You can check by looking for the
> versions in
> https://searchfox.org/mozilla-central/source/old-configure.in#2147.
> 
> gbrown: is this related to
> https://bugzilla.mozilla.org/show_bug.cgi?id=1390606?

My build-tools version is 25.0.3, the problem is with android sdk tools.

Reverting the changes from Bug 1409624 works for me, it seems to fail at the second check

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Matías Zúñiga from comment #2)
> (In reply to Nick Alexander :nalexander (less responsive until Jan 3, 2018)
> from comment #1)
> > Matias: thanks for the report!  I think that we don't support 25.2.5; we
> > require 25.0.3 for beta, I believe.  You can check by looking for the
> > versions in
> > https://searchfox.org/mozilla-central/source/old-configure.in#2147.
> > 
> > gbrown: is this related to
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1390606?
> 
> My build-tools version is 25.0.3, the problem is with android sdk tools.
> 
> Reverting the changes from Bug 1409624 works for me, it seems to fail at the
> second check

D'oh -- sorry!  Can you think about a patch that would accept both configurations?  Google likes to change these things in ways that seem random :(  Thanks!

Comment 4

[Matías Zúñiga]

Attachment: bug_1428110_-_Unset_EMULATOR_path_before_checking_again_for_it.patch

So, the problem is that autoconf firstly checks if the path is already set. Because it gets set in the first check (with a value ":"), it doesn't get set in the second check and fails.

Unsetting the autoconf variable before the second check works.

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8939922 [details] [diff] [review]
bug_1428110_-_Unset_EMULATOR_path_before_checking_again_for_it.patch

Review of attachment 8939922 [details] [diff] [review]:
-----------------------------------------------------------------

MOZ_PATH_PROG passes through to AC_PATH_PROG, and per https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html, we can check both paths in one go by separating with $PATH_SEPARATOR.  Can you try to make that work rather than using this internal autoconf variable, and report back?  Thanks!

Comment 6

[Matías Zúñiga]

(In reply to Nick Alexander :nalexander (less responsive until Jan 3, 2018) from comment #5)
> Comment on attachment 8939922 [details] [diff] [review]
> bug_1428110_-_Unset_EMULATOR_path_before_checking_again_for_it.patch
> 
> Review of attachment 8939922 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> MOZ_PATH_PROG passes through to AC_PATH_PROG, and per
> https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-
> Programs.html, we can check both paths in one go by separating with
> $PATH_SEPARATOR.  Can you try to make that work rather than using this
> internal autoconf variable, and report back?  Thanks!

$PATH_SEPARATOR is not set for me, and im not sure if i can assume ":" as the separator used by the shell, just bash and zsh are supported?

Comment 7

[Nick Alexander :nalexander [he/him]]

(In reply to Matías Zúñiga from comment #6)
> (In reply to Nick Alexander :nalexander (less responsive until Jan 3, 2018)
> from comment #5)
> > Comment on attachment 8939922 [details] [diff] [review]
> > bug_1428110_-_Unset_EMULATOR_path_before_checking_again_for_it.patch
> > 
> > Review of attachment 8939922 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > MOZ_PATH_PROG passes through to AC_PATH_PROG, and per
> > https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-
> > Programs.html, we can check both paths in one go by separating with
> > $PATH_SEPARATOR.  Can you try to make that work rather than using this
> > internal autoconf variable, and report back?  Thanks!
> 
> $PATH_SEPARATOR is not set for me, and im not sure if i can assume ":" as
> the separator used by the shell, just bash and zsh are supported?

Urgh, that sucks.  I think we can assume some things about the shell, but I'm not sure exactly what.  glandium, chmanchester -- any thoughts on how to specify two paths to MOZ_PATH_PROG in a cross-platform way?

Comment 8

[Mike Hommey [:glandium]]

Move the tests to python configure?

Comment 9

[Chris Manchester (limited bugmail, email directly)]

I'm not entirely sure, and I don't see any uses like this in old-configure today but I think assuming ":" would probably work.

Comment 10

[Matías Zúñiga]

Attachment: bug_1428110_-_Check_both_paths_of_EMULATOR_in_one_pass.patch

In that case, this works for me

Comment 11

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8940903 [details] [diff] [review]
bug_1428110_-_Check_both_paths_of_EMULATOR_in_one_pass.patch

Review of attachment 8940903 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Matías!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b96fa0adc2b3
Check both paths of EMULATOR in one pass. r=nalexander

Comment 13

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b96fa0adc2b3