1428292 - On canadiantire.ca the autofill doesn't work on the billing form

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect)

Description

[ovidiu boca[:Ovidiu]]

Affected versions]:

Tested on Nightly 59.0a1(2018-01-04)

[Affected platforms]:

Tested on Mac OS X 10.12, Windows 10

[Steps to reproduce]:

Prerequisites:
 1. Make sure you have at least two saved profile.
 
 STR:

1. Go to https://www.canadiantire.ca and buy an item
2. In the billing form double click on "First Name" or "Last Name"


[Expected result]:

The autofill suggestions are displayed. 

[Actual result]:

Nothing happens. 

NOTE: Here is a video of the actual result: https://streamable.com/uha48 
We checked after autocomplete=off but we didn't see this attribute for "First name" or "Last name".

Comment 1

[Luke Chang [:lchang] (inactive)]

I'll look into it soon.

Comment 2

[Steve Chung [:steveck]]

I just looked into it and it seems the heuristic problem that first name/ last name/address line 2/ city/ postal code/ tel fields will be detected as tel-extension, only address level 1 (province)/ country/ email/ tel-extension fields are correct. This also causes the unnecessary sectioning because of duplicate tel-extension fields, so the rest of the correct fields could not be filled because there's no sufficient valid fields in a section.

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Attachment: Bug 1428292 - Determine tel-extension in telephone parser only.

Review commit: https://reviewboard.mozilla.org/r/210860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210860/

Comment 4

[Sean Lee [:seanlee][:weilonge]]

This issue is caused by missing detection tel-extension by its regexp rule (`"\\bext|ext\\b|extension"`), and Bug 1392932 is a similar one.

I submit a WIP patch to determine tel-extension from the regexp list to telephone parser only, and there are some test fails have to be resolved.

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8940628 [details]
Bug 1428292 - Determine tel-extension in telephone parser only.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210860/diff/1-2/

Comment 7

[Sean Lee [:seanlee][:weilonge]]

This patch is based on the solution I purposed in comment 4, and it fixed the issue in bug 1392932. In addition, this patch will be rebased on bug 1417834 later since bug 1417834 is not landed yet.

Comment 8

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8940628 [details]
Bug 1428292 - Determine tel-extension in telephone parser only.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210860/diff/2-3/

Comment 9

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8940628 [details]
Bug 1428292 - Determine tel-extension in telephone parser only.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210860/diff/3-4/

Comment 10

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8940628 [details]
Bug 1428292 - Determine tel-extension in telephone parser only.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210860/diff/4-5/

Comment 11

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8940628 [details]
Bug 1428292 - Determine tel-extension in telephone parser only.

https://reviewboard.mozilla.org/r/210860/#review218076

Looks good.

Comment 12

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8940628 [details]
Bug 1428292 - Determine tel-extension in telephone parser only.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210860/diff/5-6/

Comment 13

[Sean Lee [:seanlee][:weilonge]]

Thanks for the review. The patch is rebased to the latest m-c.

Comment 14

[Dorel Luca [:dluca]]

Pushed by [e-mail]
https://hg.mozilla.org/integration/autoland/rev/860a997f95c9f7961efd94b48ffb6500afb3b1a9
Determine tel-extension in telephone parser only. r=lchang

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/860a997f95c9

Comment 16

[Lauren Fu(Firefox EPM)]

Hi Ovidiu, can you help us to verify these bug? Thanks.

Comment 17

[ovidiu boca[:Ovidiu]]

I verified this on Mac OS X 10.12, Windows 10 x64 and Ubuntu 16.04 with Nightly 59.0a1(2018-01-14) and I can confirm the fix, I will mark this as verified fixed.