1429122 - Policies: override or disable update page

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[:Felipe Gomes (needinfo for replies!)]

There's a policy request to display a custom page (or no page) on the "what's new" page that is defined through the update XML.

There's a pref to provide a default fallback if the update XML didn't provide it, but it won't be used if one was provided.

Adding this policy will be relatively straightforward here: https://searchfox.org/mozilla-central/rev/30ead7d1ae5bf95b8bc0fd67b950cd46ca05e32c/browser/components/nsBrowserContentHandler.js#142

Comment 1

[Robin Steuber (they/them) [:bytesized]]

It looks like this bug is not a priority at the moment, so I am going to work on other bugs that are. Hopefully I will be able to come back to this one afterwards.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1429122 - Policy: Override or disable post-update (what's new) page.

Review commit: https://reviewboard.mozilla.org/r/232910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232910/

Comment 3

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8964147 [details]
Bug 1429122 - Policy: Override or disable post-update (what's new) page.

https://reviewboard.mozilla.org/r/232910/#review238468

::: browser/components/enterprisepolicies/tests/browser/browser.ini:46
(Diff revision 1)
>  [browser_policy_disable_shield.js]
>  [browser_policy_disable_telemetry.js]
>  [browser_policy_display_bookmarks.js]
>  [browser_policy_display_menu.js]
>  [browser_policy_extensions.js]
> +[browser_policy_override_postupdatepage.js]

This new test file doesn't seem to have made it into the patch.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964147 [details]
Bug 1429122 - Policy: Override or disable post-update (what's new) page.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232910/diff/1-2/

Comment 5

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8964147 [details]
Bug 1429122 - Policy: Override or disable post-update (what's new) page.

https://reviewboard.mozilla.org/r/232910/#review238880

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/812669a17937
Policy: Override or disable post-update (what's new) page. r=mhowell

Comment 7

[:Felipe Gomes (needinfo for replies!)]

[Tracking Requested - why for this release]:
Enterprise Policies

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/812669a17937

Comment 9

[Abe - QA (:Abe_LV)]

We tested this on Nightly with JSON policy format and it is verified as fixed.

Using this policy, "what's new" page can be set to a website or no page.

It will also be tested with adm formats when ready.
Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964147 [details]
Bug 1429122 - Policy: Override or disable post-update (what's new) page.

Approval Request Comment
[Feature/Bug causing the regression]: Enterprise Policies
[User impact if declined]: Policy to choose or disable the "What's New" page when Firefox updates
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: -
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: limited to this policy being used, simple pref config
[String changes made/needed]: none

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8964147 [details]
Bug 1429122 - Policy: Override or disable post-update (what's new) page.

enterprise policy for 60, approved for 60.0b11

Comment 12

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-beta/rev/62543c382507e8dc18f9a8fdb6c8949be5ac89cd

Comment 13

[Abe - QA (:Abe_LV)]

We retested this on beta builds with ADM and JSON policy formats and it is verified as fixed.