1429947 - WIN64_LINK is not available in this configuration for win32 try builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Lee :Mardak]

I see some win32 builds failing on try:

my try commit directly on top of m-c with no other changes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8a443e020441ceb3f3059808a39dc22c050f8b1&filter-searchStr=build-win32

jgraham has a few pushes that failed starting from the 3rd:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd9329a1757f60fb2876e2117441ade1f490d872&filter-searchStr=build-win32

andreio:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0720ba14775f35207fe53e7a79ceebb190d29e2e&filter-searchStr=build-win32

mak:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b68f641ab5a15235b6f34ee16f9647fbc304f28&filter-searchStr=build-win32

Guessing it's bug 1401647 that touched "WIN64_LINK"?

Comment 1

[Ed Lee :Mardak]

Sorry, I meant to say jgraham's try pushes were last successful on the 3rd:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91062227fe1effb14384c3ce65608053f8167a68&filter-searchStr=build-win32

But started failing on the 8th:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ece9f13fdefe9ef230872293772d4bf5b689d585&filter-searchStr=build-win32

Comment 2

[(Away)]

Comparing the try build log to a recent successful m-c one, the most suspicious difference is:

22:10:17     INFO -    --disable-compile-environment

Comment 3

[(not currently active) Ted Mielczarek]

I thought I commented on this but apparently I never did! dmajor's analysis sounds right: this configure option is handled in toolchain.configure, which isn't loaded at all when doing artifact builds. I don't know what the best way to handle this is.

Comment 4

[Mike Hommey [:glandium]]

Do the same for WIN64_LINK as for other variables in build/mozconfig.no-compile?

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1429947 - Unset WIN64_LINK and WIN64_LIB in in-tree mozconfigs during an artifact build.

Review commit: https://reviewboard.mozilla.org/r/216018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216018/

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8945951 [details]
Bug 1429947 - Unset WIN64_LINK and WIN64_LIB in in-tree mozconfigs during an artifact build.

https://reviewboard.mozilla.org/r/216018/#review221832

Yep.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adce260df59b
Unset WIN64_LINK and WIN64_LIB in in-tree mozconfigs during an artifact build. r=nalexander

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/adce260df59b

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/272f337b122a
Keep build files in sync (Port bug 1429947: Unset WIN64_LINK and WIN64_LIB in in-tree mozconfigs during an artifact build). rs=bustage-fix