Closed Bug 1430170 Opened 6 years ago Closed 6 years ago

Regression in coverage parsing from bug 1425824

Categories

(Testing :: Code Coverage, defect)

Product:
Testing
Component:
Code Coverage
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

Patch
2.37 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
The attached patch is also asserting that grcov doesn't fail (using the `throw_exception` option of `get_ouput_from_command`). This way this won't happen again.
Attachment #8942253 - Flags: review?(jmaher)
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8942253 - Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a438b7e7917e
Use correct path to gcda file and fail build if grcov fails. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/a438b7e7917e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: