143039 - Typo in nsXmlRpcClient.js line 94

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Adam Fletcher]

Line 94 reads:

throw Components.Exceptions('Only HTTP is supported');

It should read:

throw Components.Exception('Only HTTP is supported');

The extra "s" on Exception causes an error when init'ing the XML-RPC client.
It looks liks the solution is to remove the "s" - i've searching through the
rest of the file and no other calls to Components.Exceptions exist, but plenty
of Components.Exception calls exist. I am also using the modified version for my
company's app and it works fine.

Comment 1

[mental]

Attachment: patch

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Reassigning to owner of XML-RPC.

Comment 3

[Olivier Cahagne]

Marking NEW as it has a patch.

Comment 4

[Samuel Sieb]

Why are you even hitting that line?

r=[e-mail]
heikki, can you sr?

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 82811 [details] [diff] [review]
patch

sr=heikki

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Why do we hit it, and what does it hurt?

Comment 7

[Sean Graham]

We hit it when someone (say, an enduser, or someone writing an application using
XML-RPC) tries to use XML-RPC with a protocol other than http, say https.  

Just because the typo is in an error handler doesn't mean it shouldn't be fixed.
 Someone, sooner or later, will hit this error case.

Comment 8

[Samuel Sieb]

checked in