1430517 - Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement)

Description

[James Cheng[:JamesCheng]]

we no longer needed this telemetry.

So I will remove it.

I'm not sure if ``mMaxVideoShmemsActive``

https://searchfox.org/mozilla-central/rev/137f1b2f434346a0c3756ebfcbdbee4069e15dc8/dom/media/gmp/ChromiumCDMParent.cpp#1083

is a useful information now, so I don't remove this variable in my first patch.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1430517 - Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry.

Review commit: https://reviewboard.mozilla.org/r/212808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212808/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8942557 [details]
Bug 1430517 - Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry.

https://reviewboard.mozilla.org/r/212808/#review218648

::: dom/media/gmp/ChromiumCDMParent.cpp
(Diff revision 1)
>  
>    GMP_LOG("ChromiumCDMParent::~ShutdownVideoDecoder(this=%p) "
>            "VIDEO_CHROMIUM_CDM_MAX_SHMEMS=%u",
>            this,
>            mMaxVideoShmemsActive);
> -  Telemetry::Accumulate(Telemetry::HistogramID::VIDEO_CHROMIUM_CDM_MAX_SHMEMS,

Please also remove mMaxVideoShmemsActive, it's only used by logging and the telemetry you're removing.

Comment 3

[James Cheng[:JamesCheng]]

Comment on attachment 8942557 [details]
Bug 1430517 - Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212808/diff/1-2/

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8942557 [details]
Bug 1430517 - Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry.

https://reviewboard.mozilla.org/r/212808/#review218704

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a743132915d
Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry. r=cpearce

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8a743132915d