1431251 - Remove hacks from the transition to Debian-based build images

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1431251 - Remove PKG_CONFIG_LIBDIR from mozconfigs.

As of bug 1430036 it was only set when building on CentOS, and as of bug
1432398, we don't have CentOS-based docker images anymore.

Review commit: https://reviewboard.mozilla.org/r/216056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216056/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1431251 - Remove CRT objects from the GCC build.

They were added in bug 1427344 to reduce the differences between builds
on CentOS docker images and builds on Debian docker images. We're now
entirely on Debian docker images, so we can back this out.

Review commit: https://reviewboard.mozilla.org/r/216058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216058/

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8945991 [details]
Bug 1431251 - Remove CRT objects from the GCC build.

https://reviewboard.mozilla.org/r/216058/#review221850

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8945990 [details]
Bug 1431251 - Remove PKG_CONFIG_LIBDIR from mozconfigs.

https://reviewboard.mozilla.org/r/216056/#review221852

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4808d5c01edb
Remove PKG_CONFIG_LIBDIR from mozconfigs. r=rillian
https://hg.mozilla.org/integration/autoland/rev/de16600014df
Remove CRT objects from the GCC build. r=rillian

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fb09e4b27ed4
Keep build files in sync (Port bug 1431251: Remove PKG_CONFIG_LIBDIR from mozconfigs). rs=bustage-fix DONTBUILD

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4808d5c01edb
https://hg.mozilla.org/mozilla-central/rev/de16600014df

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/comm-central/rev/262a2523f4d3
Backed out changeset fb09e4b27ed4 (Port bug 1431251: Remove PKG_CONFIG_LIBDIR from mozconfigs); rs=bustage-fix