Closed Bug 1431535 Opened 6 years ago Closed 6 years ago

Intermittent testing/marionette/harness/marionette_harness/tests/unit/test_marionette.py TestMarionette.test_disable_enable_new_connections | timeout: Timed out waiting for connection on localhost:2828!

Categories

(Testing :: Marionette Client and Harness, defect, P5)

Product:
Testing
Component:
Marionette Client and Harness
Version:
Version 3
Type:
defect

Tracking

(firefox59 fixed, firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox59 --- fixed
firefox60 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: amit2rockpower, Mentored)

Details

(Keywords: good-first-bug, intermittent-failure, Whiteboard: [lang=py])

User Story

Please check the following document which describes in how to get started. In case of questions please join the #ateam channel on irc.mozilla.org, and ask your question.

https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html

Attachments

(1 file)

Bug 1431535 Increase timeout for new connection in test_disable_enable_new_connections from timeout 1.0 to 10.0
59 bytes, text/x-review-board-request
whimboo
: review+
Details 
Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=157078044&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/Dg7jmA7vR_evFwBCiD7Xbw/runs/0/artifacts/public/logs/live_backing.log

[task 2018-01-18T06:59:06.858Z] 06:59:06     INFO -  TEST-START | testing/marionette/harness/marionette_harness/tests/unit/test_marionette.py TestMarionette.test_disable_enable_new_connections
[task 2018-01-18T06:59:23.983Z] 06:59:23  WARNING -  TEST-UNEXPECTED-ERROR | testing/marionette/harness/marionette_harness/tests/unit/test_marionette.py TestMarionette.test_disable_enable_new_connections | timeout: Timed out waiting for connection on localhost:2828!
[task 2018-01-18T06:59:23.985Z] 06:59:23     INFO -  Traceback (most recent call last):
[task 2018-01-18T06:59:23.985Z] 06:59:23     INFO -    File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 157, in run
[task 2018-01-18T06:59:23.985Z] 06:59:23     INFO -      testMethod()
[task 2018-01-18T06:59:23.986Z] 06:59:23     INFO -    File "/builds/worker/workspace/build/tests/marionette/tests/testing/marionette/harness/marionette_harness/tests/unit/test_marionette.py", line 49, in test_disable_enable_new_connections
[task 2018-01-18T06:59:23.986Z] 06:59:23     INFO -      marionette.raise_for_port(timeout=1.0)
[task 2018-01-18T06:59:23.986Z] 06:59:23     INFO -    File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 713, in raise_for_port
[task 2018-01-18T06:59:23.986Z] 06:59:23     INFO -      self.host, self.port))
[task 2018-01-18T06:59:23.987Z] 06:59:23     INFO -  TEST-INFO took 17126ms
[task 2018-01-18T06:59:24.655Z] 06:59:24     INFO -  TEST-START | testing/marionette/harness/marionette_harness/tests/unit/test_marionette.py TestMarionette.test_raise_for_port_non_existing_process
[task 2018-01-18T06:59:27.242Z] 06:59:27     INFO -  TEST-SKIP | testing/marionette/harness/marionette_harness/tests/unit/test_marionette.py TestMarionette.test_raise_for_port_non_existing_process | took 2587ms
[task 2018-01-18T06:59:28.053Z] 06:59:28     INFO -  TEST-START | testing/marionette/harness/marionette_harness/tests/unit/test_elementsize.py TestElementSize.testShouldReturnTheSizeOfALink
[task 2018-01-18T07:00:13.878Z] 07:00:13     INFO -  TEST-PASS | testing/marionette/harness/marionette_harness/tests/unit/test_elementsize.py TestElementSize.testShouldReturnTheSizeOfALink | took 45825ms
This is a failure in that line:

https://dxr.mozilla.org/mozilla-central/rev/e4107773cffb1baefd5446666fce22c4d6eb0517/testing/marionette/harness/marionette_harness/tests/unit/test_marionette.py#48-49

> self.marionette._send_message("acceptConnections", {"value": True})
> marionette.raise_for_port(timeout=1.0)

It basically means that new connections are not accepted, or that we run into a timeout because it took longer than 1s for Firefox to bring back the listening server socket.

I would propose that we increase the timeout here to 10s for the worst case.
Mentor: hskupin
User Story: (updated)
Keywords: good-first-bug
Whiteboard: [lang=py]
I'll like to work on this bug. May I have it assigned to me?
rojigan98, you are welcome to work on this bug. Per our definitions I will mark the bug as assigned once you attached a patch. In case of problems please let me know. Thanks.
Attachment #8946227 - Flags: review?(hskupin)
Thank you for your patch! Please note that when the patch is ready to also request review in the future. I did it myself now, and will have a look at it tomorrow.
Assignee: nobody → amit2rockpower
Status: NEW → ASSIGNED
Comment on attachment 8946227 [details]
Bug 1431535  Increase timeout for new connection in test_disable_enable_new_connections from timeout 1.0 to 10.0

https://reviewboard.mozilla.org/r/216198/#review222304

Thanks! The change looks fine but please have a look at the commit message, and update it. It could be done via a `hg histedit`.

Beside that I pushed the patch to try so we can see that all is still fine.

::: commit-message-a6c75:1
(Diff revision 1)
> +Bug 1431535  timeout: Timed out waiting for connection on localhost:2828!

The commit message here should be in a form like: `Bug XYZ - overview.`. Whereby overview has to mention what was fixed or got changed. So something like: `Increase timeout for new connection in test_disable_enable_new_connections.`.
Attachment #8946227 - Flags: review?(hskupin) → review-
Comment on attachment 8946227 [details]
Bug 1431535  Increase timeout for new connection in test_disable_enable_new_connections from timeout 1.0 to 10.0

https://reviewboard.mozilla.org/r/216198/#review222304

Accordingly i have made the changes , please assign me some bugs :)
Comment on attachment 8946227 [details]
Bug 1431535  Increase timeout for new connection in test_disable_enable_new_connections from timeout 1.0 to 10.0

https://reviewboard.mozilla.org/r/216198/#review222950
Attachment #8946227 - Flags: review?(hskupin) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4a42010118a
Increase timeout for new connection in test_disable_enable_new_connections from timeout 1.0 to 10.0 r=whimboo
Kamit, thank you for your first contribution! Let me know on IRC if you are interested in something more challenging.
https://hg.mozilla.org/mozilla-central/rev/b4a42010118a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Product: Testing → Remote Protocol
Moving bug to Testing::Marionette Client and Harness component per bug 1815831.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: