Closed
Bug 1433068
Opened 6 years ago
Closed 6 years ago
[CSD] LoadWidgetIconPixbuf should scale/reload titlebar button icons
Categories
(Core :: Widget: Gtk, enhancement, P2)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Bug 1408335 implements loading titlebar icons from themes, we need to also apply scale to them.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → stransky
|
|
Assignee | |
Comment 1•6 years ago
|
||
We also should reload the icons when theme is changed.
|
|
Assignee | |
Updated•6 years ago
|
Summary: [CSD] LoadWidgetIconPixbuf should scale icons → [CSD] LoadWidgetIconPixbuf should scale/reload titlebar button icons
|
|
Assignee | |
Comment 2•6 years ago
|
||
We also need to refresh nsLookAndFeel and other modules here when theme changes.
|
|
Assignee | |
Comment 3•6 years ago
|
||
nsLookAndFeel::RefreshImpl() should call WidgetCache refresh.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8952387 [details] Bug 1433068 - Reload WidgetstyleCache when theme changes, https://reviewboard.mozilla.org/r/221636/#review227550
Attachment #8952387 -
Flags: review?(jhorak) → review+
|
|
||
Comment 7•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8952388 [details] Bug 1433068 - Titlebar/Linux - load and draw HiDPI titlebar icons on HiDPI screens, https://reviewboard.mozilla.org/r/221638/#review227552 Looks good.
Attachment #8952388 -
Flags: review?(jhorak) → review+
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/76ab16daf148 Reload WidgetstyleCache when theme changes, r=jhorak https://hg.mozilla.org/integration/autoland/rev/280bf2bdcda1 Titlebar/Linux - load and draw HiDPI titlebar icons on HiDPI screens, r=jhorak
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/76ab16daf148 https://hg.mozilla.org/mozilla-central/rev/280bf2bdcda1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•