Closed
Bug 1433093
Opened 6 years ago
Closed 6 years ago
Implement RsdparsaSdpMediaSection::SetPort(unsigned int port) Rust SDP Parser bindings
Categories
(Core :: WebRTC: Signaling, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: dminor, Assigned: johannes.willbold)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
|
Reporter | |
Updated•6 years ago
|
Summary: Implement RustSdpMediaSection::SetPort(unsigned int port) Rust SDP Parser bindings → Implement RsdparsaSdpMediaSection::SetPort(unsigned int port) Rust SDP Parser bindings
|
||
Updated•6 years ago
|
Assignee: nobody → johannes.willbold
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8983239 [details] Bug 1433093: Implemented RsdparsaSdpMediaSection::SetPort. https://reviewboard.mozilla.org/r/249120/#review255466 ::: media/webrtc/signaling/gtest/sdp_unittests.cpp:3925 (Diff revision 1) > + "a=sendonly" CRLF, > + false); > + > + ASSERT_TRUE(!!mSdp) << "Parse failed: " << GetParseErrors(); > + > + auto currentPort = mSdp->GetMediaSection(0).GetPort(); Might as well check the value of currentPort here. ::: media/webrtc/signaling/src/sdp/RsdparsaSdpMediaSection.cpp:62 (Diff revision 1) > } > > void > RsdparsaSdpMediaSection::SetPort(unsigned int port) > { > - // TODO, see Bug 1433093 > + sdp_set_media_port(mSection,port); nit: please add a space after the comma
Attachment #8983239 -
Flags: review?(dminor) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by drno@ohlmeier.org: https://hg.mozilla.org/integration/autoland/rev/91ef628a1f06 Implemented RsdparsaSdpMediaSection::SetPort. r=dminor
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/91ef628a1f06
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•