Closed
Bug 1433299
Opened 6 years ago
Closed 6 years ago
Link in summary is broken
Categories
(bugzilla.mozilla.org :: User Interface, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: arai, Assigned: kohei)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
Steps to reproduce: 1. open https://bugzilla.mozilla.org/show_bug.cgi?id=1430979 2. click "bug 1193394" in summary Actual result: it opens https://bugzilla.mozilla.org/show%3Cwbr%3E_bug%3Cwbr%3E.cgi?id=1193394 Expected result: it opens https://bugzilla.mozilla.org/show_bug.cgi?id=1193394
Comment 1•6 years ago
|
||
haha, woops!
Assignee | ||
Comment 2•6 years ago
|
||
Holy s**t.
Comment 4•6 years ago
|
||
Why don't you use `overflow-wrap: break-word` instead of inserting <wbr> everywhere?
Comment 5•6 years ago
|
||
Just noticed this and was about to file a bug - Kohei, can you take this on?
Assignee | ||
Comment 6•6 years ago
|
||
Yes this is my regression... will fix it.
Updated•6 years ago
|
Assignee: kohei.yoshino → dylan
Comment 10•6 years ago
|
||
remove the wbr FILTER to restore link functionality to the summary fields.
Assignee: dylan → glob
Attachment #8954267 -
Flags: review?(dylan)
Comment 11•6 years ago
|
||
i agree with :emk that using `overflow-wrap: word-break` is the better solution; however, i keep on getting bit by this and removing the injection of <wbr> elements is a trivial change.
Assignee | ||
Comment 13•6 years ago
|
||
Using `overflow-wrap` is an easy solution, not a better solution. That's why MDN and my FxSiteCompat.com have opted for `<wbr>`. This issue can be solved by modifying the regular expression.
Assignee | ||
Comment 14•6 years ago
|
||
Comment 15•6 years ago
|
||
(In reply to Kohei Yoshino [:kohei] from comment #13) > Using `overflow-wrap` is an easy solution, not a better solution. Why?
Assignee | ||
Comment 16•6 years ago
|
||
Already explained in Bug 1428270.
Assignee | ||
Comment 17•6 years ago
|
||
Er, if I could explain a bit more, `overflow-wrap: word-break` doesn't always work well, e.g. Bug 1392433 that led to the original Bug 1428270. `<wbr>` meanwhile has been proved by other sites to work better especially with camel cases that can often been seen on BMO. Basically the `overflow-wrap` property needs a new value handling such cases properly, but I don't think it will happen soonish :S (Well, it took 2 _decades_ for CSS editors to add the `calc()` function)
Attachment #8954267 -
Attachment is obsolete: true
Attachment #8954267 -
Flags: review?(dylan)
Comment 18•6 years ago
|
||
so the wbr filter just has to be smarter.
Assignee | ||
Comment 21•6 years ago
|
||
The fix is coming today.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•