1433349 - Gnome CSD regression in Firefox 58

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect)

Description

[Thomas Drake-Brockman]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180124111618

Steps to reproduce:

Upgraded Firefox from version 57.0.4 to 58.0 via Fedora repositories.


Actual results:

Previously Gnome CSD worked correctly (with widget.allow-client-side-decoration set to true) with tabs displayed within the titlebar. Following the update the tabs display seperately below the titlebar and toggling widget.allow-client-side-decoration has no impact on how Firefox is displayed.


Expected results:

Gnome CSD should have continued to function as before.

Comment 1

[Makoto Kato [:m_kato]]

(In reply to Thomas Drake-Brockman from comment #0)
> Previously Gnome CSD worked correctly (with
> widget.allow-client-side-decoration set to true) with tabs displayed within
> the titlebar. Following the update the tabs display seperately below the
> titlebar and toggling widget.allow-client-side-decoration has no impact on
> how Firefox is displayed.

CSD feature is still development phase.  So you shouldn't file an issue for non-nightly channel now.  And, that prefs is gone on nightly.  does this issue occur on Nightly?

Comment 2

[Thomas Drake-Brockman]

On nightly (installed from https://firefox-flatpak.mojefedora.cz/) the pref widget.allow-client-side-decoration is absent. However there is a new pref browser.tabs.drawInTitlebar, which seems to control the same behaviour. Enabling this pref works as expected. Any idea on when this might land in a stable build?

Comment 3

[Thomas Drake-Brockman]

Version 58.0.1 now seems to support the browser.tabs.drawInTitlebar pref which works as expected.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

widget.allow-client-side-decoration is not longer used, browser.tabs.drawInTitlebar is the only way to switch titlebar rendering.