1433863 - [GNOME-Flashback] Can't resize window with mouse when CSD is enabled

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[m.kurz]

Attachment: without_titlebar.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36

Steps to reproduce:

Activated CSD by setting drawInTitlebar to true.

Tried to resize the firefox window with the mouse.

That didn't work.


Actual results:

Can't resize the firefox window when CSD is enabled.


Expected results:

When there is no titlebar (because activated in customize menu) I can not resize the browser windows anymore with the mouse - usually you get arrow icons as cursor as soon as you hover of the edge of the browser window. That does not happen with drawInTitlebar set to true, but works with the "old" behaviour when set to false.
Please fix this ;)

See my attached screenshot.

I am using Ubuntu 17.10.

Comment 1

[m.kurz]

Attachment: That's how it should look like and work.

Added a second screenshot where you can see the arrow mouse cursor when having CSD disabled. That is what I am expecting.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Thanks. Please run ' env | grep "XDG_" ' command on console and attach an output here.

Comment 3

[m.kurz]

Here we go:

~$ env | grep "XDG_"
XDG_MENU_PREFIX=gnome-flashback-
XDG_GREETER_DATA_DIR=/var/lib/lightdm-data/mkurz
XDG_SESSION_TYPE=x11
XDG_DATA_DIRS=/usr/share/gnome-flashback-compiz:/usr/share/gnome-flashback-compiz:/usr/local/share:/usr/share:/var/lib/snapd/desktop:/var/lib/snapd/desktop
XDG_SESSION_DESKTOP=gnome-flashback-compiz
GNOME_SESSION_XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session0
XDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0
XDG_CURRENT_DESKTOP=GNOME-Flashback:GNOME
XDG_RUNTIME_DIR=/run/user/1000
XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session0
XDG_CONFIG_DIRS=/etc/xdg/xdg-gnome-flashback-compiz:/etc/xdg/xdg-gnome-flashback-compiz:/etc/xdg

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Thanks. Can you please check your firefox build with those flags and report if the resizers/decoration looks as expected? Set to MOZ_GTK_TITLEBAR_DECORATION to "client" or "system" and run firefox, like:

$MOZ_GTK_TITLEBAR_DECORATION=client ./firefox
$MOZ_GTK_TITLEBAR_DECORATION=system ./firefox

Thanks.

Comment 5

[m.kurz]

$MOZ_GTK_TITLEBAR_DECORATION=client ./firefox
-> WORKS! ;)

$MOZ_GTK_TITLEBAR_DECORATION=system ./firefox
-> Does NOT work :(

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1433863 - Use client titlebar decorations on GNOME Flashback (former fallback) DE,

Also comment existing entries at nsWindow::GetCSDSupportLevel().

Review commit: https://reviewboard.mozilla.org/r/216208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216208/

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8946243 [details]
Bug 1433863 - Use client titlebar decorations on GNOME Flashback (former fallback) DE,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216208/diff/1-2/

Comment 8

[Jan Horak [:jhorak]]

Comment on attachment 8946243 [details]
Bug 1433863 - Use client titlebar decorations on GNOME Flashback (former fallback) DE,

https://reviewboard.mozilla.org/r/216208/#review222322

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6068ac4e1b24
Use client titlebar decorations on GNOME Flashback (former fallback) DE, r=jhorak

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6068ac4e1b24

Comment 11

[m.kurz]

Any chance this can be backported to mozilla59?