1434410 - Include information about WebRender revision in the produced captures automatically

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Dzmitry Malyshau [:kvark]]

As it turns out, getting the revision and passing it along every capture is a tedious task that is begging to be automated.

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: Include WR revision

This patch will conflict with any WR updates until merged!

Comment 2

[Dzmitry Malyshau [:kvark]]

Also, a try push just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=631f90fe4d2c6055006d14da35c4bea1d33dc2e0

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8946794 [details] [diff] [review]
Include WR revision

Review of attachment 8946794 [details] [diff] [review]:
-----------------------------------------------------------------

Commit message needs more detail. Something like "Move the WebRender revision to a separate file and include it in captures". Also remove the try syntax. For bonus points add this to your .gitconfig:

[alias]
    hgp = "show -M -C --binary --format=\"# HG changeset patch%n# User %an <%ae>%n%B\" -U8"

and then use "git hgp <cset>" to export the patch so that it will conform to the expected format for landing.

::: gfx/doc/README.webrender
@@ +178,2 @@
>  
> +The current WebRender revision can be found in gfx/webrender_bindings/revision.txt file.

Earlier in this file there is a bit that says "update the revision number at the bottom of this file" or similar, please update that text to also point to revision.txt instead

Comment 4

[Dzmitry Malyshau [:kvark]]

Attachment: Include WR revision

Thanks kats! Notes are addressed now.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8946796 [details] [diff] [review]
Include WR revision

Review of attachment 8946796 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I'll land this on inbound after the current inflight WR update merges to that branch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05f077d8f612
Move the WebRender revision to a separate file and include it in captures. r=kats

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/05f077d8f612