Closed
Bug 1435013
Opened 6 years ago
Closed 6 years ago
Offer created with offerToReceive false does not reflect the transceiver state
Categories
(Core :: WebRTC: Signaling, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla60
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
jib
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
We're missing a sync here. Fiddle to repro: https://jsfiddle.net/jib1/1h8mr8fw/
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8947565 [details] Bug 1435013: Sync transceivers before creating offers/answers. https://reviewboard.mozilla.org/r/217268/#review223114 Great, but how come the tests in bug 1425618 didn't catch this? Do we need to update them so they do? ::: dom/media/PeerConnection.js:842 (Diff revision 1) > if (transceiver.direction == "sendrecv") { > transceiver.setDirectionInternal("sendonly"); > + transceiver.sync(); > } else if (transceiver.direction == "recvonly") { > transceiver.setDirectionInternal("inactive"); > + transceiver.sync(); I count 6 calls to setDirectionInternal() in this file [1] and now two of them also call .sync() but the 4 others still do not. How come? I'm worried about maintenance here. Should maybe setDirectionInternal() itself call it? [1] https://searchfox.org/mozilla-central/search?q=setDirectionInternal(%22&case=false®exp=false&path=
Attachment #8947565 -
Flags: review?(jib) → review+
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8947565 [details] Bug 1435013: Sync transceivers before creating offers/answers. https://reviewboard.mozilla.org/r/217268/#review223114 The tests from bug 1425618 examine the transceivers only, not the SDP. The JS-side transceivers were in the correct state, but they had not synced. > I count 6 calls to setDirectionInternal() in this file [1] and now two of them also call .sync() but the 4 others still do not. How come? I'm worried about maintenance here. > > Should maybe setDirectionInternal() itself call it? > > [1] https://searchfox.org/mozilla-central/search?q=setDirectionInternal(%22&case=false®exp=false&path= I was wondering that myself. Everywhere else we've used this function has a sync at the end, so it has not been a problem before.
Assignee | ||
Comment 4•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8947565 [details] Bug 1435013: Sync transceivers before creating offers/answers. https://reviewboard.mozilla.org/r/217268/#review223114 > I was wondering that myself. Everywhere else we've used this function has a sync at the end, so it has not been a problem before. I think what I'll do is call sync on the transceivers before hitting the createOffer API.
Updated•6 years ago
|
Rank: 11
Priority: -- → P2
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•6 years ago
|
||
Ok, since I've changed the approach on this patch, it needs a re-review. Try looks good.
Flags: needinfo?(jib)
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8947565 [details] Bug 1435013: Sync transceivers before creating offers/answers. https://reviewboard.mozilla.org/r/217268/#review224056
Assignee | ||
Comment 9•6 years ago
|
||
Needinfo self to request uplift once this looks good on m-c.
Flags: needinfo?(docfaraday)
Comment 10•6 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c20f2aab0fa3 Sync transceivers before creating offers/answers. r=jib
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Tracking to make sure to follow up here and in bug 1425818, for 59 beta.
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c20f2aab0fa3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee | ||
Comment 13•6 years ago
|
||
Comment on attachment 8947565 [details] Bug 1435013: Sync transceivers before creating offers/answers. Approval Request Comment [Feature/Bug causing the regression]: Bug 1290948. [User impact if declined]: Minor web-compat problems on sites using webrtc. [Is this code covered by automated tests?]: There's a blind spot in our tests here still. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: Not really. [Why is the change risky/not risky?]: JS change only, of the belt-and-suspenders variety. [String changes made/needed]: None.
Flags: needinfo?(docfaraday)
Attachment #8947565 -
Flags: approval-mozilla-beta?
Comment 14•6 years ago
|
||
Comment on attachment 8947565 [details] Bug 1435013: Sync transceivers before creating offers/answers. Fix for regression from 59, let's uplift for 59 beta 10.
Attachment #8947565 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 15•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/3c16503565e6
You need to log in
before you can comment on or make changes to this bug.
Description
•