1435163 - Change PaymentRequest UI to support users retrying upon payment failure

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Matthew N. [:MattN]]

See bug 1435161 and https://github.com/w3c/payment-request/issues/647 for why we don't want to always close the Payment Request dialog upon failure.

Comment 1

[Matthew N. [:MattN]]

Now that bug 1435161 is resolved this is unblocked.

Comment 2

[Jean Gong :jgong]

We should follow up with Sharon on whether we need to do any retry in user testing since no real site currently support retry. We may have to customize a page specifically to test this retry user flow.

Comment 3

[Sharon Bautista (she/her) [:sbautista]]

(In reply to Jean Gong :jgong from comment #2)
> We should follow up with Sharon on whether we need to do any retry in user
> testing since no real site currently support retry. We may have to customize
> a page specifically to test this retry user flow.

It sounded like the team was interested in understanding how people perceive retry, so I think we need some version of it, even if "fake."

Comment 4

[Matthew N. [:MattN]]

Bug 1494723 will handle paymentMethod merchant errors and showing merchant errors under the pickers on the summary page

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1435163 - Show merchant address errors on billing and payer screens. r=jaws,sfoster

Comment 6

[Matthew N. [:MattN]]

After thinking about it more, since the bug 1494884 behaviour is so rare, I don't think it makes sense to test that in user testing but having the errors show below the pickers will be more useful and relevant for testing retry.

Comment 7

[Matthew N. [:MattN]]

Attachment: Bug 1435163 - Show the summary page after the processing page when retry() is called. r=jaws,sfoster

I still need to write and update tests for this.

Depends on D7149

Comment 8

[Matthew N. [:MattN]]

Attachment: Bug 1435163 - Show merchant address errors on the summary screen. r=jaws,sfoster

I still need to write and update tests for this.

Depends on D7159

Comment 9

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9012758 [details]
Bug 1435163 - Show merchant address errors on billing and payer screens. r=jaws,sfoster

Sam Foster [:sfoster] has approved the revision.

Comment 10

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9012801 [details]
Bug 1435163 - Show the summary page after the processing page when retry() is called. r=jaws,sfoster

Sam Foster [:sfoster] has approved the revision.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9012802 [details]
Bug 1435163 - Show merchant address errors on the summary screen. r=jaws,sfoster

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2d81abcb655
Show merchant address errors on billing and payer screens. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/e782c165223a
Show the summary page after the processing page when retry() is called. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/ea8385466c06
Show merchant address errors on the summary screen. r=jaws

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e2d81abcb655
https://hg.mozilla.org/mozilla-central/rev/e782c165223a
https://hg.mozilla.org/mozilla-central/rev/ea8385466c06

Comment 14

[Timea Cernea [:tbabos][inactive]]

Hi Matt,

We are not sure how to test this since on https://sfoster.github.io/payments-scratch/completeTimeout.html test-page there is no "Retry" button on the error screen as it can be seen in the design doc. 

Is there a different test-page or the above test should support retrying?

Comment 15

[Matthew N. [:MattN]]

You should test with the 3 retry pages on the site you've been testing with before:
https://rsolomakhin.github.io/

Comment 16

[Matthew N. [:MattN]]

Bug 1494884 will handle the screen when the merchant provides no errors.

Comment 17

[Timea Cernea [:tbabos][inactive]]

Thank you Matt!

Tested on the test pages from https://rsolomakhin.github.io/

1. The summary page will be displayed after the processing page when retry() is called.
2. The merchant errors will be displayed related to the specific field on the summary screen
3. The merchant errors will be displayed for the invalid fields in every Edit screen


I could also reproduce Bug 1495549 in every test page: shipping address, contact information and both of them in the same test. Waiting for it to be fixed before closing this issue.

Comment 19

[Eric Shepherd [:sheppy]]

This has been done while writing up the addition of the retry() method.

Comment 20

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 66.0a1 (2018-12-17) on Windows 10 x 64, Mac OS X 10.13 and on Ubuntu 16.04 x64.