1435306 - Cache UPluralRules and UNumberFormat for Intl.PluralRules instances

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement, P3)

Description

[André Bargull [:anba]]

Caching UPluralRules and UNumberFormat avoids creating new ones for every call to Intl.PluralRules.prototype.select.

Comment 1

[André Bargull [:anba]]

Attachment: bug1435306.patch

Adds caching for UPluralRules and UNumberFormat to Intl.PluralRules.

I've also modified intl_GetPluralCategories() to compute the available categories from an Intl.PluralRules instance instead of locale and type string arguments. This allows intl_GetPluralCategories() to use the UPluralRules caching, too. Furthermore I've removed to call to intl_GetPluralCategories() in resolvePluralRulesInternals() and instead moved it to Intl_PluralRules_resolvedOptions(). That way we only need to compute the available categories when Intl_PluralRules_resolvedOptions() is actually called.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8947911 [details] [diff] [review]
bug1435306.patch

Review of attachment 8947911 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm! Thanks!

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a07f087bead65bab769c178c3d7806a1acf3045

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3d21e203519
Cache UPluralRules and UNumberFormat for Intl.PluralRules instances. r=gandalf

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cefac2e7eb0c
followup - Fix rooting hazard. r=red CLOSED TREE

Comment 6

[Jan de Mooij [:jandem]]

anba, the rooting hazard complained because it thinks uplrules_close can GC.

The sheriffs asked about this and I pushed a follow-up fix, restructuring the code a little. Feel free to land a better fix.

Comment 7

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #6)
> the rooting hazard complained

Ugh, rooting analysis, of course.

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a3d21e203519
https://hg.mozilla.org/mozilla-central/rev/cefac2e7eb0c

Comment 9

[André Bargull [:anba]]

(In reply to Jan de Mooij [:jandem] from comment #6)
> anba, the rooting hazard complained because it thinks uplrules_close can GC.
> 
> The sheriffs asked about this and I pushed a follow-up fix, restructuring
> the code a little. Feel free to land a better fix.

The change looks good to me! Thanks for fixing it.