Closed
Bug 1435695
Opened 6 years ago
Closed 6 years ago
WebRTC fails to build with GCC 8
Categories
(Core :: WebRTC, defect, P3)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: zebob.m, Assigned: zebob.m)
Details
Attachments
(1 file)
|
2.19 KB,
patch
|
dminor
:
review+
|
Details | Diff | Splinter Review |
When trying to build Firefox trunk with GCC 8, it fails with this error: 47:23.28 /builddir/build/BUILD/gecko-dev-0517a94d022c055b2cd0b519233fa8ef8b996d04/media/webrtc/trunk/webrtc/common_audio/vad/vad_core.c:118:1: error: attributes should be specified before the declarator in a function definition 47:23.28 static inline int32_t OverflowingMulS16ByS32ToS32(int16_t a, int32_t b) 47:23.28 ^~~~~~ This was fixed upstream in commit d3cf0476b4c7923b6c0b8d25ce85769f6686b794: https://chromium.googlesource.com/external/webrtc.git/+/d3cf0476b4c7923b6c0b8d25ce85769f6686b794%5E%21/ I think you either need to backport this commit or update WebRTC to a more recent version.
|
||
Updated•6 years ago
|
Assignee: nobody → zebob.m
Rank: 25
Priority: -- → P3
|
|
||
Comment 1•6 years ago
|
||
Comment on attachment 8948350 [details] [diff] [review] firefox-nightly-60.0a1-attributes_before_declarator.patch Review of attachment 8948350 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me, I'll land it for you assuming no problems show up on this try run: https://treeherder.mozilla.org/#/jobs?repo=try&author=dminor@mozilla.com
Attachment #8948350 -
Flags: review+
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/de196fabad59 WebRTC fails to build with GCC 8; r=dminor
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/de196fabad59
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•