1437316 - Still missing reflow markers in some cases

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Markus Stange [:mstange]]

Here's a profile which contains a long reflow for which there is no marker: https://perfht.ml/2Bjeqpn

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

It looks like our marker and developer tools' marker are in different places. We are adding a marker inside `PresShell::DoFlushPendingNotifications`[1] and developer tools adding it inside `PresShell::DoReflow` method[2]. DoReflow is the inner method and DoFlushPendingNotifications eventually calls it. The problem is that `DoFlushPendingNotifications` is not the only caller of the `DoReflow` method(For example `PresShell::sPaintSuppressionCallback` also calls[3]). Therefore, we are missing some cases. I think we can also move our marker inside `DoReflow` method to fix this.

[1]: https://searchfox.org/mozilla-central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/layout/base/PresShell.cpp#4343-4347
[2]: https://searchfox.org/mozilla-central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/layout/base/PresShell.cpp#8943
[3]: https://searchfox.org/mozilla-central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/layout/base/PresShell.cpp#2028

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1437316 - Move the "PresShell::DoReflow" label frame to top side of the method r?mstange

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1437316 - Move the profiler marker from DoFlushPendingNotifications to inner DoReflow method r?mstange

Depends on D4943

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 9006278 [details]
Bug 1437316 - Move the "PresShell::DoReflow" label frame to top side of the method r?mstange

Markus Stange [:mstange] has approved the revision.

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 9006280 [details]
Bug 1437316 - Move the profiler marker from DoFlushPendingNotifications to inner DoReflow method r?mstange

Markus Stange [:mstange] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e6315642e07
Move the "PresShell::DoReflow" label frame to top side of the method r=mstange

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c05f1fdd8e44
Move the profiler marker from DoFlushPendingNotifications to inner DoReflow method r=mstange

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2e6315642e07
https://hg.mozilla.org/mozilla-central/rev/c05f1fdd8e44