Closed
Bug 1438139
Opened 6 years ago
Closed 6 years ago
Enable JS modules by default for all builds
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
|
1.23 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
7.01 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
JS module scripts were enabled by default on nightly builds just over a month ago. There haven't been any serious bugs reported in that time, so I'd like to enable this for all builds and let the feature ride the trains. What do you think?
Attachment #8950886 -
Flags: review?(bugs)
|
||
Comment 1•6 years ago
|
||
Comment on attachment 8950886 [details] [diff] [review] enable-modules right, bug 1428002 enabled modules in Nightly59.
Attachment #8950886 -
Flags: review?(bugs) → review+
|
Assignee | |
Updated•6 years ago
|
Keywords: dev-doc-needed
|
||
Updated•6 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 2•6 years ago
|
||
And here's a patch to update the tests for the new default.
Attachment #8951237 -
Flags: review?(bugs)
|
|
||
Updated•6 years ago
|
Attachment #8951237 -
Flags: review?(bugs) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9a425e7816bb Enable <script type="module"> by default r=smaug
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9a425e7816bb
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Comment 5•6 years ago
|
||
Announced on: https://developer.mozilla.org/en-US/Firefox/Releases/60#JavaScript Removed from: https://developer.mozilla.org/en-US/Firefox/Experimental_features Updated: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export Compat data: https://github.com/mdn/browser-compat-data/pull/1667 Useful guides: https://hacks.mozilla.org/2018/03/es-modules-a-cartoon-deep-dive/ https://hacks.mozilla.org/2015/08/es6-in-depth-modules/ We should also create a guide on MDN. There is bug 1393872 filed for that. Help and reviews on MDN wiki pages appreciated (as always)!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•