1438368 - Snippet blocks are still not syncing between about:home and about:newtab

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[:Gijs (he/him)]

STR:

1. ./mach run (or otherwise open nightly on a clean profile)
2. on the homepage with AS, get rid of the onboarding
3. click the [x] on the first snippet you get
4. open devtools console and check gSnippetsMap.blockList
5. open a new tab
6. open devtools console and check gSnippetsMap.blockList

ER:
they match up
AR:
they do not match up.

Comment 1

[Tim Spurway [:tspurway]]

kate, take a look at this

Comment 2

[Kate Hudson :k88hudson]

After some investigation, andrei noticed that snippets are not currently using blockSnippetById, so fixing that in snippets_as.js in snippets-server will fix part of the problem,

the other thing we talked about was adding the blocklist to snippets feed backed by IndexedDB

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ef10b886ba19e847c4ae68df567d63c774c07cb5
Fix Bug 1438368 - Syncing blocked snippets between about:home and about:newtab.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozmeao/snippets-service

https://github.com/mozmeao/snippets-service/commit/1b436e4e8640507ee01a1ef36588fc03c9779f19
Switch to gSnippetsMap.blockSnippetById (#367)

* Fix Bug 1438368 - Snippet blocks are still not syncing between about:home and about:newtab

* Remove snippets in blocklist check.

gSnippetMap.blockSnippetById() checks for duplicates.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozmeao/snippets-service

https://github.com/mozmeao/snippets-service/commit/7f515a180e2ea4e6f8602874072af5f6144b0521
Fix Bug 1438368 - Snippet blocks are still not syncing between about:home and about:newtab

https://github.com/mozmeao/snippets-service/commit/97ef9d17e5c159aa84efad4c601b53f4bdce0450
Merge branch 'bug1438368'

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9e902a91c375