1438536 - Add bool field to indicate whether direction was specified to RustSdpAttributeExtmap

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Dan Minor [:dminor]]

In rsdparsa this is already an Option<>, so we probably just need to add a bool to the RustSdpAttributeExtmap structure and set it accordingly in rsdparsa_capi.

Comment 1

[Johannes Willbold]

Attachment: Bug 1438536: Added bool field to indicate whether direction was specified to RustSdpAttributeExtmap,

Added a bool field in RustSdpAttributeExtmap that tracks whether the direction was specified.
Added the correspodning C++/Rust glue code

Review commit: https://reviewboard.mozilla.org/r/256254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256254/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8991351 [details]
Bug 1438536: Added bool field to indicate whether direction was specified to RustSdpAttributeExtmap,

https://reviewboard.mozilla.org/r/256254/#review263188

::: media/webrtc/signaling/src/sdp/RsdparsaSdpInc.h:233
(Diff revision 1)
>  // TODO: Add field indicating whether direction was specified
>  // See Bug 1438536.

I think this comment should be removed now.

Comment 3

[Johannes Willbold]

Comment on attachment 8991351 [details]
Bug 1438536: Added bool field to indicate whether direction was specified to RustSdpAttributeExtmap,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256254/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e1745b030b8
Added bool field to indicate whether direction was specified to RustSdpAttributeExtmap, r=drno

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/6e1745b030b8