Closed Bug 1439220 Opened 6 years ago Closed 6 years ago

Port Bug 1437040 "Remove synchronous Bookmarks::GetItemIndex" to SeaMonkey

Categories

(SeaMonkey :: Bookmarks & History, enhancement)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.58 fixed, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.58
Tracking Flags:
Tracking Status
seamonkey2.58 --- fixed
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.1)

Attachments

(2 files, 1 obsolete file)

1439220-places-getItemIndex.patch
1.03 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-beta+
frg
: approval-comm-release+
Details | Diff | Splinter Review
1439220-places-getItemIndex-glue.patch
16.46 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-beta+
frg
: approval-comm-release+
Details | Diff | Splinter Review 
Bug 1378089 needs to be fixed first.

The smart bookmarks code in nsSuiteGlue.js also uses this and needs a bigger upgrade for this.
places part first. 1:1 patch
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Both patches need Bug 1378089 fixed first so not setting review.
Blocks: 942937
Rebased after Bug 1436605 landed.
Attachment #8953519 - Attachment is obsolete: true
Comment on attachment 8951971 [details] [diff] [review]
1439220-places-getItemIndex.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 1437040 
User impact if declined: broken boookmarks 
Testing completed (on m-c, etc.): comm-beta
Risk to taking this patch (and alternatives if risky): --
String changes made by this patch: --
Attachment #8951971 - Flags: review?(iann_bugzilla)
Attachment #8951971 - Flags: approval-comm-beta?
Comment on attachment 8955776 [details] [diff] [review]
1439220-places-getItemIndex-glue.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 1437040 
User impact if declined: broken boookmarks 
Testing completed (on m-c, etc.): comm-beta
Risk to taking this patch (and alternatives if risky): --
String changes made by this patch: --
Attachment #8955776 - Flags: review?(iann_bugzilla)
Attachment #8955776 - Flags: approval-comm-beta?
Comment on attachment 8951971 [details] [diff] [review]
1439220-places-getItemIndex.patch

LGTM r/a=me
Attachment #8951971 - Flags: review?(iann_bugzilla)
Attachment #8951971 - Flags: review+
Attachment #8951971 - Flags: approval-comm-beta?
Attachment #8951971 - Flags: approval-comm-beta+
Comment on attachment 8955776 [details] [diff] [review]
1439220-places-getItemIndex-glue.patch

LGTM r/a=me
Attachment #8955776 - Flags: review?(iann_bugzilla)
Attachment #8955776 - Flags: review+
Attachment #8955776 - Flags: approval-comm-beta?
Attachment #8955776 - Flags: approval-comm-beta+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/11ede8b087c1
Port Bug 1437040 "Remove synchronous Bookmarks::GetItemIndex" to SeaMonkey. r=IanN
https://hg.mozilla.org/comm-central/rev/06878aedff3f
Align smart bookmark initialisation with browser. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

Combined patch target 2.53.1:
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/4bb832471cac9e22508a2b4d19e5e818d9eff309
Align smart bookmark initialisation with browser.
Port Bug 1094888 [Smart bookmarks creation in nsBrowserGlue should use the new Bookmarks.jsm API].

status-seamonkey2.53: affected → fixed
Attachment #8951971 - Flags: approval-comm-release+
Attachment #8955776 - Flags: approval-comm-release+
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: