Closed
Bug 1440146
Opened 6 years ago
Closed 6 years ago
Remove unused menubutton-item binding
Categories
(Core :: XUL, task)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: bgrins, Assigned: enndeakin)
References
Details
(Whiteboard: [xbl-available])
Attachments
(1 file)
|
1.58 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
This is bound to `menuitem.menuitem-non-iconic`, but I can't find any hits of menuitem-non-iconic besides the css selector attaching the binding. * https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/toolkit/content/xul.css#376
|
Reporter | |
Comment 1•6 years ago
|
||
comm-central has a single hit in `calendar/` so this'll likely need to be ported (or change the element to not use it anymore): https://searchfox.org/comm-central/search?q=menuitem-non-iconic&path=
|
||
Updated•6 years ago
|
Assignee: nobody → enndeakin
|
Assignee | |
Comment 2•6 years ago
|
||
The reference in calendar isn't affected since the class is incorrectly applied to a menulist rather than a menuitem.
Attachment #8956076 -
Flags: review?(bgrinstead)
|
|
Reporter | |
Comment 3•6 years ago
|
||
Comment on attachment 8956076 [details] [diff] [review] menuitem-unused-binding Review of attachment 8956076 [details] [diff] [review]: ----------------------------------------------------------------- Thanks
Attachment #8956076 -
Flags: review?(bgrinstead) → review+
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/33d3f93924ac remove unused menubutton-item binding, r=bgrins
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/33d3f93924ac
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•6 years ago
|
status-firefox60:
--- → fixed
|
||
Comment 6•6 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•