1440828 - Phabricator review requests should show up on the BMO dashboard

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: MyDashboard, defect)

Description

[Botond Ballo [:botond]]

Unlike Splinter and MozReview review requests, Phabricator review requests do not show up on the BMO dashboard, because Phabricator does not set r? flags in Bugzilla.

I'm told that having Phabricator set r? flags in Bugzilla has technical challenges. I would be happy with a solution that allowed Phabricator review requests to show up on the BMO dashboard without setting r? flags (e.g. via a BMO extension that adds a new section to the dashboard).

However, I think that no longer having a single place to look at all your requests (needinfo, review, etc.) would be an unfortunate productivity regression.

Comment 1

[Mark Côté [:mcote]]

I'll have to think about this, but it's an interesting idea.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

This is one of the biggest drags when using Phabricator for me, fwiw.

Comment 3

[:glob ✱]

Attachment: pr

Comment 4

[:Gijs (he/him)]

Mark's post on m.d.platform talks about "my dashboard" and "notifications indicator". Will this patch also cause the review requests to show up in the request.cgi pages, or should I file a separate bug for that? It's not really clear from the discussion here.

Comment 5

[David Lawrence [:dkl]]

(In reply to :Gijs from comment #4)
> Mark's post on m.d.platform talks about "my dashboard" and "notifications
> indicator". Will this patch also cause the review requests to show up in the
> request.cgi pages, or should I file a separate bug for that? It's not really
> clear from the discussion here.

As coded in the PR for this bug, no. But if you would like to file a separate bug we can look 
at extending requests.cgi to also show the phabricator requests in its own table. It can just
reuse the same code from the PR.

dkl