144128 - [FIX]API Freeze - Need to create PrintSettings w/o nsIWebBrowserPrint

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[rods (gone)]

There needs to be a service for creating the nsIPrintSettings objects and then
remove them from nsIWebBrowserPrint.

Because there times when you will need to get a PrintSettings object and you do
not have a nsIWebBrowserPrint object.

The new service "nsIPrintSettingsService" will be implemented by nsPrintOptions
and I have already filed a bug 144114 for switch over the impl's name.

For now, nsIPrintOptions and nsIPrintSettingsService will have the same CID
because the same object implements both services. NOTE: only internal classes
will ever need to create a nsIPrintOptions object.

Comment 1

[rods (gone)]

Attachment: patch

Problem: You cannot create a PrintSettings object without a nsIWebBrowserPrint
iface which requires a loaded document. 

Solution: Move the creation and manipulation of PSs to their own service.

This patch does the following:
1) Introduces a new public interface nsIPrintSettingService which emables
consumers to create PS objects whithout a nsIWebBrowserPrint interface
2) The implementation is nsPrintOptionsImpl which now impls the private
interface nsIPrintOptions and the public iface nsIPrintSettingsService
3) Several methods/attrs have been moved from nsIWebBrowserPrint iface to
nsIPrintSettingsService
4) The CIDs for nsIPrintOptions and nsIPrinSettingsService are now the same.
5) There is no longer a CID "@mozilla.org/gfx/printoptions;1" 
6) nsIWebBrowserPrint still has the "globalPrintSettings" attr so if you
already have an nsIWebBrowserPrint you don't have to create the PS Service to
get it.
7) A bug has been filed to rename the imlp of nsPrintOptionsImpl to
nsPrintSettingsService.

Comment 2

[Marc Attinasi]

Comment on attachment 83351 [details] [diff] [review]
patch

sr=attinasi, assuming you document the transitional nature as we discussed on
the phone.

Comment 3

[Kevin McCluskey (gone)]

topembed+

Comment 4

[rods (gone)]

Attachment: missed this mac build file

Comment 5

[rods (gone)]

fixed

Comment 6

[dcone (gone)]

Comment on attachment 83351 [details] [diff] [review]
patch

r=dcone

Comment 7

[sujay]

printing and page setup work in 5/15 build.

Comment 8

[rods (gone)]

Reopening, I messed a directory when making the patch and checking in

Comment 9

[rods (gone)]

Attachment: mailnews part of patch

I missed this dir for patch and checkin

Comment 10

[dcone (gone)]

Comment on attachment 83920 [details] [diff] [review]
mailnews part of patch

r=dcone

Comment 11

[kinmoz]

Comment on attachment 83920 [details] [diff] [review]
mailnews part of patch

sr=[e-mail]

Comment 12

[rods (gone)]

ducarroz says dcone's r= is fine - fixed.

Comment 13

[sujay]

Rod, can you verify this and mark verified-fixed? thanks.

Comment 14

[scottputterman]

adding adt1.0.0+.  Please get drivers approval and then check into the 1.0 branch.

Comment 15

[sujay]

marking verified...

Comment 16

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.

Comment 17

[Judson Valeski]

please land on the 1.0.1 branch. once there, remove the "mozilla1.0.1+" keyword,
and add the "fixed1.0.1" keyword.

Comment 18

[rods (gone)]

checked in on branch