1441668 - editMenuOverlay.xul removal

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Brendan Dahl [:bdahl]]

A heads up...over in bug 1439766 I will be removing editMenuOverlay.xul.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1441668-editmenuoverlay-wip.patch

Might work but need to check if we need to move individual keys. Really bad compared to just including the overlay but can't be helped. If someone else wants to finish it be my guest.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1441668-WIP-editmenuoverlay-257.patch

Rebased 2.57 wip patch

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1441668-WIP-editmenuoverlay.patch

Rebased c-c wip patch

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1441668-editmenuoverlay-257.patch

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1441668-editmenuoverlay-cc.patch

comm-central version

Comment 6

[Ian Neal]

Comment on attachment 9140551 [details] [diff] [review]
1441668-editmenuoverlay-257.patch

The only place that still seems to need editMenuOverlay.dtd is placesOverlay.xul, so it can be removed from the rest of the code:
>+++ b/suite/components/console/content/console.xul
> <!DOCTYPE window [
>   <!ENTITY % console SYSTEM "chrome://communicator/locale/console/console.dtd"> %console;
>+  <!ENTITY % editMenuDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd"> %editMenuDTD;
> ]>
As there will be only one dtd file, just turn this into a single line <!DOCTYPE window SYSTEM...

>+++ b/suite/components/downloads/content/downloadmanager.xul
> <!DOCTYPE window [
> <!ENTITY % downloadsDTD SYSTEM "chrome://communicator/locale/downloads/downloadmanager.dtd">
> %downloadsDTD;
> <!ENTITY % editMenuOverlayDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
> %editMenuOverlayDTD;
These two lines can be removed.

>+++ b/suite/components/places/content/history-panel.xul
> <!DOCTYPE page [
> <!ENTITY % placesDTD SYSTEM "chrome://communicator/locale/places/places.dtd">
> %placesDTD;
>+<!ENTITY % editMenuOverlayDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
>+ %editMenuOverlayDTD;
> ]>
As there will be only one dtd file, just turn this into a single line <!DOCTYPE page SYSTEM...

>+++ b/suite/components/places/content/places.xul
> <!DOCTYPE window [
> <!ENTITY % placesDTD SYSTEM "chrome://communicator/locale/places/places.dtd">
> %placesDTD;
> <!ENTITY % editMenuOverlayDTD SYSTEM "chrome://global/locale/editMenuOverlay.dtd">
> %editMenuOverlayDTD;
These two lines can be removed.

r/a=me with those addressed.

Comment 7

[Ian Neal]

Comment on attachment 9140553 [details] [diff] [review]
1441668-editmenuoverlay-cc.patch

Same comments as for the other patch, r =me with those addressed.

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: 1441668-editmenuoverlay-V1_1-cc.patch

Updated comm-central patch r+ from IanN retained. Additional fixes as discussed via irc.

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: 1441668-editmenuoverlay-V1_1-257.patch

Updated 2.57 patch. r/a+ from IanN retained. Additional fixes as discussed via irc.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e0aed4844492
Replace editMenuOverlay.xul in SeaMonkey with preprocessed includes. r=IanN

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7e0a7e7cf046
Follow-up fix build bustage. r=frg