Closed
Bug 1441844
Opened 6 years ago
Closed 6 years ago
Remove unused --chrome-nav-bar-separator-color variable
Categories
(Firefox :: Theme, enhancement, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jaws, Assigned: uoftcsc, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file)
2.35 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
The last reference to this was removed by bug 1349555.
Reporter | ||
Comment 1•6 years ago
|
||
Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.
Comment 2•6 years ago
|
||
https://searchfox.org/mozilla-central/search?q=chrome-nav-bar-separator-color&case=true&path=
Mentor: dao+bmo
Keywords: good-first-bug
Summary: --chrome-nav-bar-separator-color is defined but not referenced → Remove unused --chrome-nav-bar-separator-color variable
Whiteboard: [lang=css]
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 3•6 years ago
|
||
I'd like to work on this
Comment 4•6 years ago
|
||
(In reply to Jon K from comment #3) > I'd like to work on this Go ahead. :) Have you built Firefox yet? Do you know what files to modify and how to submit a patch?
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #4) > (In reply to Jon K from comment #3) > > I'd like to work on this > > Go ahead. :) Have you built Firefox yet? Do you know what files to modify > and how to submit a patch? Yes and I believe so. I will report back if I run into any problems.
Comment 6•6 years ago
|
||
Can I work on this?
Comment 7•6 years ago
|
||
(In reply to paarmita1998 from comment #6) > Can I work on this? I'm not sure if Jon is still working on this. Jon?
Flags: needinfo?(uoftcsc)
Assignee | ||
Comment 8•6 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #7) > (In reply to paarmita1998 from comment #6) > > Can I work on this? > > I'm not sure if Jon is still working on this. Jon? Yes, I will attach the patch within a day.
Flags: needinfo?(uoftcsc)
Assignee | ||
Comment 9•6 years ago
|
||
This is my first patch, please let me know if there are any issues I should change.
Comment 10•6 years ago
|
||
Comment on attachment 8958336 [details] [diff] [review] Bug 1441844: Remove unused --chrome-nav-bar-separator-color variable Perfect, thanks!
Attachment #8958336 -
Flags: review+
Updated•6 years ago
|
Assignee: nobody → uoftcsc
Comment 11•6 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f1e6aeb55b95 Remove unused --chrome-nav-bar-separator-color variable. r=dao
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f1e6aeb55b95
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•