1442300 - --in-content-category-background is defined but never referenced

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The property is defined at https://searchfox.org/mozilla-central/rev/769222fadff46164f8cc0dc7a0bae5a60dc2f335/browser/themes/shared/incontentprefs/preferences.inc.css#13 but never referenced.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.

Comment 2

[Brian]

Hi, I am new here, could I work on this as my first bug?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Go ahead. :) Have you built Firefox yet? Do you know what files to modify and
how to submit a patch?

Comment 4

[Brian]

Thanks for the quick reply! And yep, I have built Firefox on my VM. Should I be editing preferences.inc.css or browser_parsable_css.js? I've tried preferences.inc.css as it was the original post. I've also looked at some of the documentation for submitting a patch.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

You will have to edit both of those files, since browser_parsable_css.js has a whitelist entry for it that will need to be removed once you remove the value from the preferences.inc.css file.

Comment 6

[Brian]

Attachment: 1442300.patch

Hi, I have posted a patch. Can you review it please?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8958255 [details] [diff] [review]
1442300.patch

Review of attachment 8958255 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Can you please export your changes? This diff is missing your author line which will give you proper attribution.

You should follow the steps at https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html to configure your machine to use MozReview, then you can use the steps at https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html to push this patch to MozReview. From there I can review it again and push your changes to our autoland repository (where it will eventually get merged to mozilla-central).

This is a bit of upfront work but it will make submitting your future patches much easier.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebffbbe870e5
Remove --in-content-category-background property since it is unused. r=jaws

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

I've pushed your patch for you. There shouldn't be any more work necessary for this bug. I will keep my eyes out for another bug that you can work on :)

Thanks!

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ebffbbe870e5