Closed
Bug 1443599
Opened 6 years ago
Closed 6 years ago
Stop reporting legacy Telemetry component `childPayloads`
Categories
(Toolkit :: Telemetry, enhancement, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: chutten, Assigned: janerik)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.66 KB,
patch
|
chutten
:
review+
|
Details | Diff | Splinter Review |
This bug is for stopping childPayloads from being reported by TelemetrySession (basically just removing https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/toolkit/components/telemetry/TelemetrySession.jsm#1332 ) and updating the documentation and tests as necessary. We aim to complete this work in Firefox 61.
status-firefox60:
--- → affected
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8960121 -
Flags: review?(chutten)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jrediger
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 8960121 [details] [diff] [review] Stop reporting legacy Telemetry component `childPayloads` Review of attachment 8960121 [details] [diff] [review]: ----------------------------------------------------------------- It didn't occur to me when I was splitting the "stop" from the "remove" probes that leaving all that code in place during "stop" would be painful to r+ :S Ah well, so much the sweeter when time comes to remove it. And I'd like to note that you didn't have to change any tests here. That's one of the many reasons for removing these. I do find it interesting that no changes had to be made to aboutTelemetry. The code's just generic enough to handle it.
Attachment #8960121 -
Flags: review?(chutten) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d006cb03572 Stop reporting legacy Telemetry component `childPayloads`. r=chutten
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4d006cb03572
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•