1446009 - Remove groupbox-base binding by moving groupbox.css into components.css (or by flattening it into the groupbox binding)

Status: RESOLVED FIXED

(Core :: XUL, task)

Description

[Brian Grinstead [:bgrins]]

groupbox-base is only extended by groupbox, and only loads a css file: https://searchfox.org/mozilla-central/rev/8fa0b32c84f924c6809c690117dbd59591f79607/toolkit/content/widgets/groupbox.xml#12.

This would make it an easy candidate for flattening into groupbox, but since this CSS is also loaded by caption (same file), we may want to take the opportunity to move the CSS into components.css to make future Custom Element migration easier, and to add another data point for what this kind CSS move will entail. 

Looking at the groupbox.css files (https://searchfox.org/mozilla-central/search?q=groupbox.css&path=) I don't *think* we'd need to make any changes to them, unless if one of the selectors is used outside of the groupbox/caption bindings, in which case we'd now be applying that CSS to nodes that didn't used to get it.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1446009 - Remove groupbox-base binding by moving groupbox.css into components.css

Review commit: https://reviewboard.mozilla.org/r/229230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229230/

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=61985f03214fac9c69c36b92da3e71008e0a1fc1&newProject=try&newRev=54e908f832b645b97aec521758d73b7d58f329d9

(Reusing base commit from bug 1446163)

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

For some reason, your review flag didn't register on MozReview. Could you do that on MozReview again?

Comment 4

[Neil Deakin]

Comment on attachment 8960465 [details]
Bug 1446009 - Remove groupbox-base binding by moving groupbox.css into components.css

https://reviewboard.mozilla.org/r/229230/#review235464

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a32a6c5e7a7
Remove groupbox-base binding by moving groupbox.css into components.css r=enndeakin+6102

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9a32a6c5e7a7

Comment 7

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336