Closed
Bug 1448544
Opened 6 years ago
Closed 6 years ago
bustage at xpcom/threads/SchedulerGroup.cpp:67:16: error: 'class mozilla::SchedulerGroup::Runnable' has no member named 'GetName' when Gecko 61 merges to Beta on 2018-04-26
Categories
(Core :: XPCOM, defect, P1)
Core
XPCOM
Tracking
()
VERIFIED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | blocking | verified |
People
(Reporter: aryx, Assigned: froydnj)
References
Details
Attachments
(1 file)
6.95 KB,
patch
|
farre
:
review+
|
Details | Diff | Splinter Review |
Regression from bug 1447744. central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e9bf98b32fca04328de9b203435d2147c5798a9&selectedJob=170035712 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=170035689&repo=try [task 2018-03-24T10:34:04.899Z] 10:34:04 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads1.cpp:2:0: [task 2018-03-24T10:34:04.900Z] 10:34:04 INFO - /builds/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp: In constructor '{anonymous}::AutoCollectVsyncTelemetry::AutoCollectVsyncTelemetry(mozilla::SchedulerGroup::Runnable*)': [task 2018-03-24T10:34:04.900Z] 10:34:04 INFO - /builds/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp:67:16: error: 'class mozilla::SchedulerGroup::Runnable' has no member named 'GetName' [task 2018-03-24T10:34:04.900Z] 10:34:04 INFO - aRunnable->GetName(mKey); [task 2018-03-24T10:34:04.901Z] 10:34:04 INFO - ^~~~~~~ Once fixed, Linux and Windows opt will still be busted in beta simulations (bug 1448070).
Flags: needinfo?(nfroyd)
Reporter | ||
Comment 1•6 years ago
|
||
This only affects early beta.
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
We had this for Quantum DOM, but that effort is stalled/dead, so we should just remove the code and associated Telemetry histograms.
Attachment #8962482 -
Flags: review?(afarre)
Assignee | ||
Comment 3•6 years ago
|
||
Sigh, I wondered if that code was going to bust things. :(
Assignee: nobody → nfroyd
Flags: needinfo?(nfroyd)
Updated•6 years ago
|
Attachment #8962482 -
Flags: review?(afarre) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/09670a66e09a remove AutoVsyncTelemetry; r=farre
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/09670a66e09a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Reporter | ||
Comment 7•6 years ago
|
||
Thank you. Verified fixed in the latest central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7193c554d26cbfa22f3a124527a31ee898fed64a&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•