1449547 - Unreadable "Hide Bookmarks Sidebar" menu on Dark theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[atlanto]

Attachment: screenshot

(app menu->)Library->Bookmarks->Bookmarking Tools->Hide Bookmarks Sidebar
filled with dark color.

Hover makes it normal.(color is white on hover)
"View Bookmarks Sidebar" is not affected.(no problem)
Linux only.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

This is caused by this ruleset,
https://searchfox.org/mozilla-central/rev/7ccb618f45a1398e31a086a009f87c8fd3a790b6/toolkit/themes/linux/global/toolbarbutton.css#60-62

Comment 2

[Tim Nguyen :ntim]

Dão, do you know if this ruleset can be removed or should it be overriden in panelUI.inc.css ?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Tim Nguyen :ntim from comment #2)
> Dão, do you know if this ruleset can be removed or should it be overriden in
> panelUI.inc.css ?

Afaik Gtk themes tend to render -moz-appearance: toolbarbutton; opaque in the checked state (as well as hover, active and open), so this would still be needed.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1449547 - Make subviewbuttons override the toolkit default color for checked toolbarbuttons.

Review commit: https://reviewboard.mozilla.org/r/246704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246704/

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8980545 [details]
Bug 1449547 - Make subviewbuttons override the toolkit default color for checked toolbarbuttons.

https://reviewboard.mozilla.org/r/246704/#review253002

Comment 7

[Tim Nguyen :ntim]

Thanks for picking this up :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb31cfa8b634
Make subviewbuttons override the toolkit default color for checked toolbarbuttons. r=jaws

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 8980545 [details]
Bug 1449547 - Make subviewbuttons override the toolkit default color for checked toolbarbuttons.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1408121
[User impact if declined]: attachment 8963091 [details] and attachment 8980362 [details] 
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: see comment 0 and bug 1463720
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: css only
[String changes made/needed]:

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cb31cfa8b634

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8980545 [details]
Bug 1449547 - Make subviewbuttons override the toolkit default color for checked toolbarbuttons.

More dark theme improvements. Approved for 61.0b9.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/abead84db088

Comment 13

[Anca Soncutean, Desktop QA]

I could observe this issue on Firefox 61.0a1 (2018-03-28) under Ubuntu 16.04 x64.
The bug is fixed on Firefox 62.0a1 (2018-05-28) and Firefox 61.0b9 ( 20180528091514) under Ubuntu 16.04 x64, Ubuntu 14.04 x32, Windows 10 x64 and macOS 10.13.