Closed
Bug 1450761
Opened 6 years ago
Closed 6 years ago
Policy: Hide "Add Exception" on certificate error
Categories
(Firefox :: Enterprise Policies, enhancement)
Tracking
()
VERIFIED
FIXED
Firefox 61
People
(Reporter: Felipe, Assigned: Felipe)
References
Details
Attachments
(3 files)
Hide the Add Exception button
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8964393 [details] Bug 1450761 - Add pref to disable the Add Exception button on certificate error pages. https://reviewboard.mozilla.org/r/233116/#review238572 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: browser/base/content/test/about/browser_aboutCertError.js:348 (Diff revision 1) > + > + for (let useFrame of [false, true]) { > + let tab = await openErrorPage(BAD_CERT, useFrame); > + let browser = tab.linkedBrowser; > + > + let message = await ContentTask.spawn(browser, {frame: useFrame}, async function({frame}) { Error: 'message' is assigned a value but never used. [eslint: no-unused-vars]
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8964393 [details] Bug 1450761 - Add pref to disable the Add Exception button on certificate error pages. https://reviewboard.mozilla.org/r/233116/#review238884 ::: browser/base/content/aboutNetError.xhtml:373 (Diff revision 2) > > // set the checkbox > checkbox.checked = !!options.automatic; > } > + if (options && options.disableAddExceptionButton) { > + document.getElementById("exceptionDialogButton").disabled = true; I don't see what good disabling the button but keeping it visible does. There's nothing that the user can do to enable the button so it will just be a tease.
Attachment #8964393 -
Flags: review?(jaws) → review-
Assignee | ||
Comment 7•6 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6) > Comment on attachment 8964393 [details] > Bug 1450761 - Add pref to disable the Add Exception button on certificate > error pages. > > https://reviewboard.mozilla.org/r/233116/#review238884 > > ::: browser/base/content/aboutNetError.xhtml:373 > (Diff revision 2) > > > > // set the checkbox > > checkbox.checked = !!options.automatic; > > } > > + if (options && options.disableAddExceptionButton) { > > + document.getElementById("exceptionDialogButton").disabled = true; > > I don't see what good disabling the button but keeping it visible does. > There's nothing that the user can do to enable the button so it will just be > a tease. This has been the UX direction that we're following for Policies. Every policy is disabling items instead of hiding them, so this is just to keep consistent with the other policies.
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8964394 [details] Bug 1450761 - Policy to disable the Add Exception button on certificate error pages. https://reviewboard.mozilla.org/r/233118/#review238888
Attachment #8964394 -
Flags: review?(jaws) → review+
Comment 9•6 years ago
|
||
(In reply to :Felipe Gomes (needinfo me!) from comment #7) > (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6) > > Comment on attachment 8964393 [details] > > Bug 1450761 - Add pref to disable the Add Exception button on certificate > > error pages. > > > > https://reviewboard.mozilla.org/r/233116/#review238884 > > > > ::: browser/base/content/aboutNetError.xhtml:373 > > (Diff revision 2) > > > > > > // set the checkbox > > > checkbox.checked = !!options.automatic; > > > } > > > + if (options && options.disableAddExceptionButton) { > > > + document.getElementById("exceptionDialogButton").disabled = true; > > > > I don't see what good disabling the button but keeping it visible does. > > There's nothing that the user can do to enable the button so it will just be > > a tease. > > This has been the UX direction that we're following for Policies. Every > policy is disabling items instead of hiding them, so this is just to keep > consistent with the other policies. In the prefs we include a string explaining why some items are disabled but we don't do that on this screen. We should bring this up with UX.
Comment 10•6 years ago
|
||
:amin is out on PTO until tomorrow and I understand that this has a high priority to land soon so this can be uplifted to Beta. I talked to :shorlander and he agreed with hiding the button in this case: "[U]nless we are going to add some way to explain why it is disabled, I agree that a it should be hidden and not disabled ("Greyed out"). Although that does make the "Advanced --> Show Info that does nothing" flow kind of strange. Anyway, future improvements aside, I agree we shouldn't show a disabled button that has no context around why it is disabled."
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8964393 [details] Bug 1450761 - Add pref to disable the Add Exception button on certificate error pages. https://reviewboard.mozilla.org/r/233116/#review239310 r=me if you switch to hiding instead of disabling.
Attachment #8964393 -
Flags: review- → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 14•6 years ago
|
||
Pushed by felipc@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ca550bc9020b Add pref to disable the Add Exception button on certificate error pages. r=jaws https://hg.mozilla.org/integration/mozilla-inbound/rev/4a473ea3d1bf Policy to disable the Add Exception button on certificate error pages. r=jaws
Assignee | ||
Comment 15•6 years ago
|
||
Comment 16•6 years ago
|
||
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/62839ba7b41c Follow-up, remove check that was added in the previous version of the patch, but is not needed anymore. r=fgomes
Assignee | ||
Comment 17•6 years ago
|
||
[Tracking Requested - why for this release]:
tracking-firefox60:
--- → ?
Summary: Policy: Disable "Add Exception" on certificate error → Policy: Hide "Add Exception" on certificate error
Comment 18•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ca550bc9020b https://hg.mozilla.org/mozilla-central/rev/4a473ea3d1bf https://hg.mozilla.org/mozilla-central/rev/62839ba7b41c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
status-firefox60:
--- → affected
Comment 19•6 years ago
|
||
We tested this on the latest nightly with JSON policy format and it is verified as fixed. With this policy, "Add Exception" option on certificate error pages can be disabled (hidden). We will retest this with adm policy format when ready. Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760
Assignee | ||
Comment 20•6 years ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/e5906299c4ac89b2e92029028e748eaa7f4e59cf
Assignee | ||
Comment 21•6 years ago
|
||
uplift |
This other cset is also part of this bug: https://hg.mozilla.org/releases/mozilla-beta/rev/94b99a3d55b2dfedb3c2bf829f991b894ad7a7bd
Comment 22•6 years ago
|
||
We retested this on beta builds[FX60] with ADM and JSON policy formats and it is verified as fixed. Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760
You need to log in
before you can comment on or make changes to this bug.
Description
•