1450930 - The Page Down/Up keys doesn't work after pressing Home/End keys

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, defect)

Description

[roxleitan]

[Affected versions]:
Nightly 61.0a1

[Affected Platforms]:
Ubuntu 16.04 x64, Windows 10 x64

[Prerequisites]:
- Have the latest try build 61.0a1 from (2018-03-27) installed.
- Accessibility is enabled and accessibility tab is opened

[Steps to reproduce]:
1.Click on down arrows from Role area to expand until the scrollbar is displayed on the right side of the panel
2.Press End key
3.Press Home key
4.Press Page down key

[Expected result]:
The Role content area should be scrolled down

[Actual result]:
Nothing happens

Comment 1

[Timea Cernea [:tbabos][inactive]]

[Affected versions]:
Latest Nightly 61.0a1, Build ID: 20180410100115

[Affected Platforms]:
Windows 10 x64

Further testing revealed that the issue could be reproduced also with the "Home" and "End" keys if the Page Up/Page down keys are pressed before. 

[Steps to reproduce]:
1. Click on down arrows from Role area to expand until the scrollbar is displayed on the right side of the panel
2. Press Home key
3. Press Page Down key once
4. Press Home key 
5. Observe the issue
6. Repeat the steps by replacing Home and Page Down with End key and Page Up key

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1450930 - The Page Down/Up keys doesn't work after pressing Home/End keys.

Review commit: https://reviewboard.mozilla.org/r/249656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249656/

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8983840 [details]
Bug 1450930 - The Page Down/Up keys doesn't work after pressing Home/End keys.

https://reviewboard.mozilla.org/r/249656/#review256328

This looks good. We might want to open a new bug for improving scroll into view overall, where we would only scroll if necessary.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can't reproduce the reported issue on my machine (Win10, Firefox m-c)

Here is what I am doing:

1) load any page
2) open the Accessibility panel and click on "Turn On Accessibility Features" 
3) Clicking on the "Document" entry in the Role area (to make sure the focus is there), but not on the arrow, so it stays collapsed.
4) Pressing arrow-right key to expand the entry (not arrow-down as indicated in comment #0)
5) Pressing arrow-down to move down in the list and expanding other entries to make sure the vertical scrollbar appears
6) Pressing Home properly selects the first entry ("document") and scrolls to the top, so the selection is visible
7) Pressing End properly selects the last entry and scrolls to the bottom, so the selection is visible
8) Pressing PageUp scrolls up one page, but doesn't change the selection
9) Pressing PageDown scrolls down one page, but doesn't change the selection

Where is the problem?
What am I doing wrong?

Honza

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Jan Honza Odvarko [:Honza] from comment #4)
> I can't reproduce the reported issue on my machine (Win10, Firefox m-c)
> 
> Here is what I am doing:
> 
> 1) load any page
> 2) open the Accessibility panel and click on "Turn On Accessibility
> Features" 
> 3) Clicking on the "Document" entry in the Role area (to make sure the focus
> is there), but not on the arrow, so it stays collapsed.
> 4) Pressing arrow-right key to expand the entry (not arrow-down as indicated
> in comment #0)
> 5) Pressing arrow-down to move down in the list and expanding other entries
> to make sure the vertical scrollbar appears
> 6) Pressing Home properly selects the first entry ("document") and scrolls
> to the top, so the selection is visible

After this step try:

* Press PageDown (so the first element is out of sight), nothing new is selected.
* Press Home again, the scroll does not happen because we have a check for current selection and stop if it does not change (which it did not, since the first element is always selected).

> 7) Pressing End properly selects the last entry and scrolls to the bottom,
> so the selection is visible
> 8) Pressing PageUp scrolls up one page, but doesn't change the selection
> 9) Pressing PageDown scrolls down one page, but doesn't change the selection
> 
> Where is the problem?
> What am I doing wrong?
> 
> Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8983840 [details]
Bug 1450930 - The Page Down/Up keys doesn't work after pressing Home/End keys.

https://reviewboard.mozilla.org/r/249656/#review257908

I was able to repro the issue using STR in comment #5

Looks good and works for me.
R+ assuming Try is green

Thanks for the patch!

Honza

Comment 7

[Micah [:mtigley] (she/her)]

Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e429423b586b1f49f64256bace5676dc4a6be2a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40b467f38306
The Page Down/Up keys doesn't work after pressing Home/End keys. r=Honza,yzen

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/40b467f38306