Closed
Bug 1451845
Opened 6 years ago
Closed 6 years ago
use SkCanvas layer clip image for DrawTargetSkia::PushLayer mask
Categories
(Core :: Graphics, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
Details
(Keywords: feature, Whiteboard: [gfx-noted])
Attachments
(1 file)
7.15 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Skia has had its clip image support in SkCanvas layers stabilized for a while. Using this allows us to get rid of old hacks I had made to DrawTargetSkia, and also allows me to remove several custom patches to moz-skia that were needed to make my hacks work. Less stuff for me to maintain and brings us closer to Skia trunk.
Attachment #8965429 -
Flags: review?(jmuizelaar)
Comment 1•6 years ago
|
||
Comment on attachment 8965429 [details] [diff] [review] use SkCanvas layer clip image for DrawTargetSkia::PushLayer mask Review of attachment 8965429 [details] [diff] [review]: ----------------------------------------------------------------- That's a refreshing patch!
Attachment #8965429 -
Flags: review?(jmuizelaar) → review+
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2daf28697874 use SkCanvas layer clip image for DrawTargetSkia::PushLayer mask. r=jrmuizel
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2daf28697874
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•