1454016 - Quantum Lights theme is completely broken in today's nightly

Status: VERIFIED FIXED

(WebExtensions :: Themes, defect)

Description

[Dave Townsend [:mossop]]

Updating to today's nightly and with Quantum Lights theme applied the UI is just a bright white/gray colour, not the nice theme that Martell intended.

Comment 1

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=52ec9a6c12a1c235e91d5baba6d92a7eba33c951&tochange=f3e01de682f1a39c4a906423823def6f8804ad49

Looks like this was caused by bug 1443561

Comment 2

[Chris Peterson [:cpeterson]]

I can repro on Mac, but WFM on Windows 10.

Note that the Quantum Lights extension is temporarily unavailable in AMO:

https://twitter.com/mart3ll/status/981168333448912898

Comment 3

[Vivek]

I can look into this. Can you share a screenshot of how it looks like on OSX currently, while I set up my macbook?

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: Quantum_Lights_screenshot.jpg

Here is a screenshot of Quantum Lights on my Mac.

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: Quantum_Lights_{ed26ddcb-5611-4512-a89a-51b8db81cfb2}.xpi

Here is a copy of the Quantum Lights xpi since the extension is temporarily unavailable on AMO.

Comment 6

[Vivek]

Issue was tracked down to https://searchfox.org/mozilla-central/source/toolkit/themes/osx/global/toolbar.css#10 in OSX.
Bug 1443561 has been backed out for now till a better fix can be written. Quantum lights should work as expected now.

Comment 7

[Dave Townsend [:mossop]]

This is working again now.

Comment 8

[marius.santa]

Attachment: quantum lights working.JPG

Issue reproduced in Firefox 61.0a1 (20180413100443) on macOS 10.13.4.
Retested and verified on Firefox 61.0 (20180621125625) in Windows 10 64Bit and macOS 10.13.4.

Comment 9

[marius.santa]

Retested and verified on Firefox 61.0a1 (20180413220147) in Windows 10 64Bit and macOS 10.13.4.