1454980 - Let POMTP tiling with skia on windows ride the trains

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

This is the bug to track letting bug 1454978 ride the trains.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Manual testing passed.

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: pomtp-trains.patch

With all outstanding bugs resolved and manual testing passed, I think we are good to let this ride the trains.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8981481 [details] [diff] [review]
pomtp-trains.patch

Review of attachment 8981481 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c587c9fb7de
Let tiled parallel skia on unaccelerated windows ride the trains. r=davidb

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9c587c9fb7de

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

This already landed, but we can track it to make sure to catch if it reopens.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this something you'd like in the release notes for 62?

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Yes and thanks for catching Liz. Probably best to get a one-liner straight from Ryan.

Comment 9

[Ryan Hunt [:rhunt] (on leave until early May)]

I looked at some past release notes for OMTP and wrote one. Feel free to workshop it.

"Improved graphics rendering using Parallel-Off-Main-Thread Painting (P-OMTP) for Windows users without accelerated hardware (P-OMTP for OSX was released in Firefox 60)"

Note: I looked back at the release notes for Firefox 60 and noticed that P-OMTP being enabled on OSX was not mentioned there. It must have gotten lost somehow. It was originally enabled in bug 1430793.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Firefox 62 release notes.