1457718 - Perma-failing toolkit/components/extensions/test/xpcshell/test_ext_experiments.js fail after beta uplift

Status: VERIFIED FIXED

(WebExtensions :: Experiments, defect)

Description

[Andreea Pavel [:apavel]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f938ffb6df8e0dcd469d44df87988596477e104&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&group_state=expanded&selectedJob=176167488

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=176167488&repo=try&lineNumber=2567

This began perma-failing after beta simulations.

Comment 1

[Andrei Ciure[:aciure]]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1457718 - test_ext_experiments.js result depends on MOZ_ALLOW_LEGACY_EXTENSIONS.

Review commit: https://reviewboard.mozilla.org/r/240628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240628/

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This fails test case #5 https://hg.mozilla.org/mozilla-central/rev/fa02de71ebf7#l3.28 because that fails experimentsAllowed https://dxr.mozilla.org/mozilla-central/rev/08f68e2c892cadc4035ecbfbf3529f32d40f1fd9/toolkit/components/extensions/Extension.jsm#1417 due to ALLOW_LEGACY_EXTENSIONS only allowed for Nightly and DevEdition https://dxr.mozilla.org/mozilla-central/search?q=ALLOW_LEGACY_EXTENSIONS

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8971898 [details]
Bug 1457718 - test_ext_experiments.js result depends on MOZ_ALLOW_LEGACY_EXTENSIONS.

https://reviewboard.mozilla.org/r/240628/#review246290

Thanks

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4252c770699c
test_ext_experiments.js result depends on MOZ_ALLOW_LEGACY_EXTENSIONS. r=kmag

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/4252c770699c

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2b9ccfead9cd586470bb658a58baa0c289d2e27&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&group_state=expanded