1458004 - Link font-style values italic / oblique to the appropriate variation-font axes or synthetic styling

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement, P2)

Description

[Jonathan Kew [:jfkthame]]

font-style:italic should use an italic face if available, or set the 'ital' variation to 1.0 if present; or use a 14° synthetic-slant as fallback.

font-style:oblique should use a face declared as oblique, or set the 'slnt' axis to the specified value (default 14); or use a synthetic slant of the specified angle.

(In both cases, synthetic slant is only used if font-synthesis includes the 'style' value.)

Comment 1

[Jonathan Kew [:jfkthame]]

This will build on top of the font-weight handling from bug 1449605.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Link font-style values italic / oblique to the appropriate variation-font axes or synthetic styling

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 8972139 [details] [diff] [review]
Link font-style values italic / oblique to the appropriate variation-font axes or synthetic styling

Review of attachment 8972139 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxFontEntry.cpp
@@ +1133,5 @@
> +    if (!mCheckedForVariationAxes) {
> +        CheckForVariationAxes();
> +    }
> +
> +    return (mRangeFlags & RangeFlags::eItalicVariation) ==

You don't need the ==. If you're worried about this being misread you could write it as the following which I think is a bit more readable:

  return bool(mRangeFlags & RangeFlags::eItalicVariation);

::: gfx/thebes/gfxFontEntry.h
@@ +662,5 @@
> +{
> +    return SlantStyle().Max().IsItalic() ||
> +           ((mRangeFlags & RangeFlags::eAutoSlantStyle) ==
> +               RangeFlags::eAutoSlantStyle &&
> +            HasItalicVariation());

Again, I'd prefer not to have the == personally.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18cf597d218b
Link font-style values italic / oblique to the appropriate variation-font axes or synthetic styling. r=jwatt

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/18cf597d218b

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/18cf597d218b