Closed
Bug 145803
Opened 22 years ago
Closed 22 years ago
Implement url autocomplete
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: winnie, Assigned: hewitt)
References
Details
Attachments
(1 file, 1 obsolete file)
20.42 KB,
patch
|
Details | Diff | Splinter Review |
Implement url autocomplete.
Reporter | ||
Updated•22 years ago
|
QA Contact: petersen → winnie
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•22 years ago
|
||
This patch implements full url autocomplete, just like in Mozilla.
Assignee | ||
Comment 2•22 years ago
|
||
This patch implements full url autocomplete, just like in Mozilla.
Assignee | ||
Updated•22 years ago
|
Attachment #85220 -
Attachment is obsolete: true
Comment 3•22 years ago
|
||
+ mIconImage = [[NSImage imageNamed:@"globe_ico"] autorelease]; NSImage's are already autoreleased. i fixed this, but FYI. + [self setDelegate: self]; shouldn't this be done in IB? + if (mProxyIcon != nil) { just |if (mProxyIcon) {| + mDataSource = [[[CHAutoCompleteDataSource alloc] init] retain]; retain is implied by the alloc. this will leak. again, i fixed it. i also noticed that hitting esc doesn't make it dismiss, and if i click outside it, it loads the url i click on in the content area. maybe that's ok, but it just makes the popup very hard to dismiss w/out consequences.
Assignee | ||
Updated•22 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•22 years ago
|
||
fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•